Issue 14773032: Revert 182659 "Get a filename of dumped heap profile in a V8 ext..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14773032: Revert 182659 "Get a filename of dumped heap profile in a V8 ext..." (Closed)

Created:
7 years, 7 months ago by Dai Mikurube (NOT FULLTIME)

Modified:
7 years, 7 months ago

Reviewers:
Dai Mikurube (NOT FULLTIME)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 182659 "Get a filename of dumped heap profile in a V8 ext..." > Get a filename of dumped heap profile in a V8 extension HeapProfilerDump(). > > > BUG=chromium-os:38652 > TBR=darin@chromium.org > > > Review URL: https://chromiumcodereview.appspot.com/12212157 TBR=dmikurube@chromium.org

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -38 lines)			Patch
M	trunk/src/content/renderer/memory_benchmarking_extension.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	trunk/src/third_party/tcmalloc/chromium/src/gperftools/heap-profiler.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	trunk/src/third_party/tcmalloc/chromium/src/heap-profiler.cc	View	5 chunks	+11 lines, -23 lines	0 comments	Download

Total messages: 2 (0 generated)

Dai Mikurube (NOT FULLTIME)

7 years, 7 months ago (2013-05-15 13:54:45 UTC) #2

Message was sent while issue was closed.

Done in https://codereview.chromium.org/14969026/