Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: Source/WebKit/chromium/src/WebDOMEvent.cpp

Issue 14773025: Create ResourceProgressEvent, expose as Chromium API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: (merge) Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/src/WebDOMEvent.cpp
diff --git a/Source/WebKit/chromium/src/WebDOMEvent.cpp b/Source/WebKit/chromium/src/WebDOMEvent.cpp
index f72170cfa7eaba433ee127f0ee941985b5a965ec..d5fd463d7efc5c313b7b8db75178a6f29c56ee54 100644
--- a/Source/WebKit/chromium/src/WebDOMEvent.cpp
+++ b/Source/WebKit/chromium/src/WebDOMEvent.cpp
@@ -56,12 +56,17 @@ void WebDOMEvent::assign(const WebDOMEvent& other)
assign(p);
}
-void WebDOMEvent::assign(WebDOMEventPrivate* p)
+void WebDOMEvent::assign(WebDOMEventPrivate* event)
{
- // p is already ref'd for us by the caller
+ // event is already ref'd for us by the caller
if (m_private)
m_private->deref();
abarth-chromium 2013/05/20 21:16:32 Ouch. We should remove this function. It's askin
dmichael (off chromium) 2013/05/23 16:47:00 Good point, I fixed it in a separate CL: https://c
- m_private = p;
+ m_private = event;
+}
+
+void WebDOMEvent::assign(const WTF::PassRefPtr<WebDOMEventPrivate>& event)
+{
+ assign(event.leakRef());
abarth-chromium 2013/05/20 21:16:32 Can't we just assign m_private directly? The raw
dmichael (off chromium) 2013/05/23 16:47:00 Done.
}
WebDOMEvent::WebDOMEvent(const WTF::PassRefPtr<WebCore::Event>& event)
« no previous file with comments | « Source/WebKit/chromium/public/WebDOMResourceProgressEvent.h ('k') | Source/WebKit/chromium/src/WebDOMProgressEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698