Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 14773013: Rename BarInfo to BarProp and remove [NoInterfaceObject] attribute (Closed)

Created:
7 years, 7 months ago by do-not-use
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, lgombos
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename BarInfo to BarProp and remove [NoInterfaceObject] attribute The BarInfo interface should be named BarProp and it should NOT have the [NoInterfaceObject] extended attribute according to the specification: http://www.w3.org/html/wg/drafts/html/master/browsers.html#barprop This patch addresses both issues and makes the behavior consistent with the specification and Firefox. BUG=239422 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -241 lines) Patch
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +3 lines, -3 lines 0 comments Download
D Source/core/page/BarInfo.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/core/page/BarInfo.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/core/page/BarInfo.idl View 1 chunk +0 lines, -34 lines 0 comments Download
A + Source/core/page/BarProp.h View 2 chunks +11 lines, -11 lines 0 comments Download
A + Source/core/page/BarProp.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
A + Source/core/page/BarProp.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/page/DOMWindow.h View 3 chunks +13 lines, -14 lines 0 comments Download
M Source/core/page/DOMWindow.cpp View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/core/page/DOMWindow.idl View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
do-not-use
7 years, 7 months ago (2013-05-09 14:31:12 UTC) #1
arv (Not doing code reviews)
LGTM I'm a bit split on this. We should remove these properties. They are not ...
7 years, 7 months ago (2013-05-09 15:08:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14773013/1
7 years, 7 months ago (2013-05-09 15:11:46 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_bare_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_bare_presubmit&number=719
7 years, 7 months ago (2013-05-09 15:17:56 UTC) #4
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-09 15:28:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/14773013/1
7 years, 7 months ago (2013-05-09 15:28:50 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 17:19:18 UTC) #7
Message was sent while issue was closed.
Change committed as 150032

Powered by Google App Engine
This is Rietveld 408576698