Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1477233002:
Export BreakEvent and CompileEvent (Closed)
DescriptionExport BreakEvent and CompileEvent
R=yangguo@chromium.org
Committed: https://crrev.com/b201a7b93f35a3d66c319038d0f3419c7bd935cc
Cr-Commit-Position: refs/heads/master@{#32861}
Patch Set 1 #Patch Set 2 : remove the comment comment about JetBrains #Patch Set 3 : export BreakPoint #Patch Set 4 : add "Vladimir Krivosheev <develar@gmail.com>" to AUTHORS #Patch Set 5 : move name "Vladimir Krivosheev <develar@gmail.com>" into alphabetically sorted order in AUTHORS #Messages
Total messages: 30 (9 generated)
On 2015/11/26 15:43:15, develar wrote: So, we (Jetbrains) can fix https://youtrack.jetbrains.com/issue/WEB-16397 not only for nodejs v4, but for v5 also. Our debugger protocol implementation adds scriptParsed event with sourceMapUrl (it works much better on VM side since VM has access to actual script source).
On 2015/11/26 15:47:27, develar wrote: > On 2015/11/26 15:43:15, develar wrote: > > So, we (Jetbrains) can fix https://youtrack.jetbrains.com/issue/WEB-16397 not > only for nodejs v4, but for v5 also. Our debugger protocol implementation adds > scriptParsed event with sourceMapUrl (it works much better on VM side since VM > has access to actual script source). We are currently rethinking how to interface with Chrome Devtools. I'd rather not expose yet another ad-hoc API in the JS part of the debugger that may eventually break.
On 2015/11/26 20:37:32, Yang wrote: > On 2015/11/26 15:47:27, develar wrote: > > On 2015/11/26 15:43:15, develar wrote: > > > > So, we (Jetbrains) can fix https://youtrack.jetbrains.com/issue/WEB-16397 not > > only for nodejs v4, but for v5 also. Our debugger protocol implementation adds > > scriptParsed event with sourceMapUrl (it works much better on VM side since VM > > has access to actual script source). > > We are currently rethinking how to interface with Chrome Devtools. I'd rather > not expose yet another ad-hoc API in the JS part of the debugger that may > eventually break. Thanks for information. It will be cool — not to reinvent yet another debugger protocol, but use WIP. We are happy to use WIP and we don't have issues with it. If possible, please inform me when it will be available to test prior to release. Bit I think, new WIP will be not implemented soon (several months), right? So, until that, may be you can apply so simple patch? The problem is — our solution works in nodejs v4 (all events are exposed), but doesn't work in v5 (new version of V8).
On 2015/11/27 06:57:33, develar wrote: > On 2015/11/26 20:37:32, Yang wrote: > > On 2015/11/26 15:47:27, develar wrote: > > > On 2015/11/26 15:43:15, develar wrote: > > > > > > So, we (Jetbrains) can fix https://youtrack.jetbrains.com/issue/WEB-16397 > not > > > only for nodejs v4, but for v5 also. Our debugger protocol implementation > adds > > > scriptParsed event with sourceMapUrl (it works much better on VM side since > VM > > > has access to actual script source). > > > > We are currently rethinking how to interface with Chrome Devtools. I'd rather > > not expose yet another ad-hoc API in the JS part of the debugger that may > > eventually break. > > Thanks for information. It will be cool — not to reinvent yet another debugger > protocol, but use WIP. We are happy to use WIP and we don't have issues with it. > If possible, please inform me when it will be available to test prior to > release. > > Bit I think, new WIP will be not implemented soon (several months), right? So, > until that, may be you can apply so simple patch? The problem is — our solution > works in nodejs v4 (all events are exposed), but doesn't work in v5 (new version > of V8). toJSONProtocol is not used by Chromium. I'd be more comfortable upstreaming the changes you apply to it, if they are reasonable. And also, please remove the comment about JetBrains. V8 is not directly affiliated to JetBrains.
On 2015/11/27 07:46:24, Yang wrote: > On 2015/11/27 06:57:33, develar wrote: > > On 2015/11/26 20:37:32, Yang wrote: > > > On 2015/11/26 15:47:27, develar wrote: > > > > On 2015/11/26 15:43:15, develar wrote: > > > > > > > > So, we (Jetbrains) can fix https://youtrack.jetbrains.com/issue/WEB-16397 > > not > > > > only for nodejs v4, but for v5 also. Our debugger protocol implementation > > adds > > > > scriptParsed event with sourceMapUrl (it works much better on VM side > since > > VM > > > > has access to actual script source). > > > > > > We are currently rethinking how to interface with Chrome Devtools. I'd > rather > > > not expose yet another ad-hoc API in the JS part of the debugger that may > > > eventually break. > > > > Thanks for information. It will be cool — not to reinvent yet another debugger > > protocol, but use WIP. We are happy to use WIP and we don't have issues with > it. > > If possible, please inform me when it will be available to test prior to > > release. > > > > Bit I think, new WIP will be not implemented soon (several months), right? So, > > until that, may be you can apply so simple patch? The problem is — our > solution > > works in nodejs v4 (all events are exposed), but doesn't work in v5 (new > version > > of V8). > > toJSONProtocol is not used by Chromium. I'd be more comfortable upstreaming the > changes you apply to it, if they are reasonable. And also, please remove the > comment about JetBrains. V8 is not directly affiliated to JetBrains. >> I'd be more comfortable upstreaming the changes you apply to i Our implementation — https://gist.github.com/develar/6365b609dc94047bd9fb But only addition of sourceMapUrl field is reasonable. If logic is ok for you (lines 38-44 https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts... — https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts...), I will prepare patch. >> toJSONProtocol is not used by Chromium Yep, I understand, it is the reason why WIP outperforms V8 protocol ;)
On 2015/11/27 08:27:50, develar wrote: > On 2015/11/27 07:46:24, Yang wrote: > > On 2015/11/27 06:57:33, develar wrote: > > > On 2015/11/26 20:37:32, Yang wrote: > > > > On 2015/11/26 15:47:27, develar wrote: > > > > > On 2015/11/26 15:43:15, develar wrote: > > > > > > > > > > So, we (Jetbrains) can fix > https://youtrack.jetbrains.com/issue/WEB-16397 > > > not > > > > > only for nodejs v4, but for v5 also. Our debugger protocol > implementation > > > adds > > > > > scriptParsed event with sourceMapUrl (it works much better on VM side > > since > > > VM > > > > > has access to actual script source). > > > > > > > > We are currently rethinking how to interface with Chrome Devtools. I'd > > rather > > > > not expose yet another ad-hoc API in the JS part of the debugger that may > > > > eventually break. > > > > > > Thanks for information. It will be cool — not to reinvent yet another > debugger > > > protocol, but use WIP. We are happy to use WIP and we don't have issues with > > it. > > > If possible, please inform me when it will be available to test prior to > > > release. > > > > > > Bit I think, new WIP will be not implemented soon (several months), right? > So, > > > until that, may be you can apply so simple patch? The problem is — our > > solution > > > works in nodejs v4 (all events are exposed), but doesn't work in v5 (new > > version > > > of V8). > > > > toJSONProtocol is not used by Chromium. I'd be more comfortable upstreaming > the > > changes you apply to it, if they are reasonable. And also, please remove the > > comment about JetBrains. V8 is not directly affiliated to JetBrains. > > >> I'd be more comfortable upstreaming the changes you apply to i > Our implementation — https://gist.github.com/develar/6365b609dc94047bd9fb But > only addition of sourceMapUrl field is reasonable. If logic is ok for you (lines > 38-44 > https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts... > — > https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts...), > I will prepare patch. sounds good. > > >> toJSONProtocol is not used by Chromium > Yep, I understand, it is the reason why WIP outperforms V8 protocol ;) V8's JSON debug protocol is only in place for legacy reasons.
On 2015/11/27 08:31:58, Yang wrote: > On 2015/11/27 08:27:50, develar wrote: > > On 2015/11/27 07:46:24, Yang wrote: > > > On 2015/11/27 06:57:33, develar wrote: > > > > On 2015/11/26 20:37:32, Yang wrote: > > > > > On 2015/11/26 15:47:27, develar wrote: > > > > > > On 2015/11/26 15:43:15, develar wrote: > > > > > > > > > > > > So, we (Jetbrains) can fix > > https://youtrack.jetbrains.com/issue/WEB-16397 > > > > not > > > > > > only for nodejs v4, but for v5 also. Our debugger protocol > > implementation > > > > adds > > > > > > scriptParsed event with sourceMapUrl (it works much better on VM side > > > since > > > > VM > > > > > > has access to actual script source). > > > > > > > > > > We are currently rethinking how to interface with Chrome Devtools. I'd > > > rather > > > > > not expose yet another ad-hoc API in the JS part of the debugger that > may > > > > > eventually break. > > > > > > > > Thanks for information. It will be cool — not to reinvent yet another > > debugger > > > > protocol, but use WIP. We are happy to use WIP and we don't have issues > with > > > it. > > > > If possible, please inform me when it will be available to test prior to > > > > release. > > > > > > > > Bit I think, new WIP will be not implemented soon (several months), right? > > So, > > > > until that, may be you can apply so simple patch? The problem is — our > > > solution > > > > works in nodejs v4 (all events are exposed), but doesn't work in v5 (new > > > version > > > > of V8). > > > > > > toJSONProtocol is not used by Chromium. I'd be more comfortable upstreaming > > the > > > changes you apply to it, if they are reasonable. And also, please remove the > > > comment about JetBrains. V8 is not directly affiliated to JetBrains. > > > > >> I'd be more comfortable upstreaming the changes you apply to i > > Our implementation — https://gist.github.com/develar/6365b609dc94047bd9fb But > > only addition of sourceMapUrl field is reasonable. If logic is ok for you > (lines > > 38-44 > > > https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts... > > — > > > https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts...), > > I will prepare patch. > > sounds good. > > > > > >> toJSONProtocol is not used by Chromium > > Yep, I understand, it is the reason why WIP outperforms V8 protocol ;) > > V8's JSON debug protocol is only in place for legacy reasons. For some reasons I cannot add my RegExp to mirrors.js (patch https://gist.github.com/develar/b8a9f1d61f5c65939871) — I got error Exception thrown during bootstrapping Extension or internal compilation error: Unexpected token % in native mirrors.js at line 40. It seems, preprocessor of this native file should be somehow modified.
On 2015/11/27 15:43:13, develar wrote: > On 2015/11/27 08:31:58, Yang wrote: > > On 2015/11/27 08:27:50, develar wrote: > > > On 2015/11/27 07:46:24, Yang wrote: > > > > On 2015/11/27 06:57:33, develar wrote: > > > > > On 2015/11/26 20:37:32, Yang wrote: > > > > > > On 2015/11/26 15:47:27, develar wrote: > > > > > > > On 2015/11/26 15:43:15, develar wrote: > > > > > > > > > > > > > > So, we (Jetbrains) can fix > > > https://youtrack.jetbrains.com/issue/WEB-16397 > > > > > not > > > > > > > only for nodejs v4, but for v5 also. Our debugger protocol > > > implementation > > > > > adds > > > > > > > scriptParsed event with sourceMapUrl (it works much better on VM > side > > > > since > > > > > VM > > > > > > > has access to actual script source). > > > > > > > > > > > > We are currently rethinking how to interface with Chrome Devtools. I'd > > > > rather > > > > > > not expose yet another ad-hoc API in the JS part of the debugger that > > may > > > > > > eventually break. > > > > > > > > > > Thanks for information. It will be cool — not to reinvent yet another > > > debugger > > > > > protocol, but use WIP. We are happy to use WIP and we don't have issues > > with > > > > it. > > > > > If possible, please inform me when it will be available to test prior to > > > > > release. > > > > > > > > > > Bit I think, new WIP will be not implemented soon (several months), > right? > > > So, > > > > > until that, may be you can apply so simple patch? The problem is — our > > > > solution > > > > > works in nodejs v4 (all events are exposed), but doesn't work in v5 (new > > > > version > > > > > of V8). > > > > > > > > toJSONProtocol is not used by Chromium. I'd be more comfortable > upstreaming > > > the > > > > changes you apply to it, if they are reasonable. And also, please remove > the > > > > comment about JetBrains. V8 is not directly affiliated to JetBrains. > > > > > > >> I'd be more comfortable upstreaming the changes you apply to i > > > Our implementation — https://gist.github.com/develar/6365b609dc94047bd9fb > But > > > only addition of sourceMapUrl field is reasonable. If logic is ok for you > > (lines > > > 38-44 > > > > > > https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts... > > > — > > > > > > https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts...), > > > I will prepare patch. > > > > sounds good. > > > > > > > > >> toJSONProtocol is not used by Chromium > > > Yep, I understand, it is the reason why WIP outperforms V8 protocol ;) > > > > V8's JSON debug protocol is only in place for legacy reasons. > > For some reasons I cannot add my RegExp to mirrors.js (patch > https://gist.github.com/develar/b8a9f1d61f5c65939871) — I got error > > Exception thrown during bootstrapping > Extension or internal compilation error: Unexpected token % in native mirrors.js > at line 40. > > It seems, preprocessor of this native file should be somehow modified. hm... I did not realize that your change was so involved and specific. Let's go back to your original patch sans comment.
On 2015/11/27 16:10:13, Yang wrote: > On 2015/11/27 15:43:13, develar wrote: > > On 2015/11/27 08:31:58, Yang wrote: > > > On 2015/11/27 08:27:50, develar wrote: > > > > On 2015/11/27 07:46:24, Yang wrote: > > > > > On 2015/11/27 06:57:33, develar wrote: > > > > > > On 2015/11/26 20:37:32, Yang wrote: > > > > > > > On 2015/11/26 15:47:27, develar wrote: > > > > > > > > On 2015/11/26 15:43:15, develar wrote: > > > > > > > > > > > > > > > > So, we (Jetbrains) can fix > > > > https://youtrack.jetbrains.com/issue/WEB-16397 > > > > > > not > > > > > > > > only for nodejs v4, but for v5 also. Our debugger protocol > > > > implementation > > > > > > adds > > > > > > > > scriptParsed event with sourceMapUrl (it works much better on VM > > side > > > > > since > > > > > > VM > > > > > > > > has access to actual script source). > > > > > > > > > > > > > > We are currently rethinking how to interface with Chrome Devtools. > I'd > > > > > rather > > > > > > > not expose yet another ad-hoc API in the JS part of the debugger > that > > > may > > > > > > > eventually break. > > > > > > > > > > > > Thanks for information. It will be cool — not to reinvent yet another > > > > debugger > > > > > > protocol, but use WIP. We are happy to use WIP and we don't have > issues > > > with > > > > > it. > > > > > > If possible, please inform me when it will be available to test prior > to > > > > > > release. > > > > > > > > > > > > Bit I think, new WIP will be not implemented soon (several months), > > right? > > > > So, > > > > > > until that, may be you can apply so simple patch? The problem is — our > > > > > solution > > > > > > works in nodejs v4 (all events are exposed), but doesn't work in v5 > (new > > > > > version > > > > > > of V8). > > > > > > > > > > toJSONProtocol is not used by Chromium. I'd be more comfortable > > upstreaming > > > > the > > > > > changes you apply to it, if they are reasonable. And also, please remove > > the > > > > > comment about JetBrains. V8 is not directly affiliated to JetBrains. > > > > > > > > >> I'd be more comfortable upstreaming the changes you apply to i > > > > Our implementation — https://gist.github.com/develar/6365b609dc94047bd9fb > > But > > > > only addition of sourceMapUrl field is reasonable. If logic is ok for you > > > (lines > > > > 38-44 > > > > > > > > > > https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts... > > > > — > > > > > > > > > > https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts...), > > > > I will prepare patch. > > > > > > sounds good. > > > > > > > > > > > >> toJSONProtocol is not used by Chromium > > > > Yep, I understand, it is the reason why WIP outperforms V8 protocol ;) > > > > > > V8's JSON debug protocol is only in place for legacy reasons. > > > > For some reasons I cannot add my RegExp to mirrors.js (patch > > https://gist.github.com/develar/b8a9f1d61f5c65939871) — I got error > > > > Exception thrown during bootstrapping > > Extension or internal compilation error: Unexpected token % in native > mirrors.js > > at line 40. > > > > It seems, preprocessor of this native file should be somehow modified. > > hm... I did not realize that your change was so involved and specific. Let's go > back to your original patch sans comment. Comment removed, BreakPoint is also exported.
On 2015/12/10 11:52:08, develar wrote: > On 2015/11/27 16:10:13, Yang wrote: > > On 2015/11/27 15:43:13, develar wrote: > > > On 2015/11/27 08:31:58, Yang wrote: > > > > On 2015/11/27 08:27:50, develar wrote: > > > > > On 2015/11/27 07:46:24, Yang wrote: > > > > > > On 2015/11/27 06:57:33, develar wrote: > > > > > > > On 2015/11/26 20:37:32, Yang wrote: > > > > > > > > On 2015/11/26 15:47:27, develar wrote: > > > > > > > > > On 2015/11/26 15:43:15, develar wrote: > > > > > > > > > > > > > > > > > > So, we (Jetbrains) can fix > > > > > https://youtrack.jetbrains.com/issue/WEB-16397 > > > > > > > not > > > > > > > > > only for nodejs v4, but for v5 also. Our debugger protocol > > > > > implementation > > > > > > > adds > > > > > > > > > scriptParsed event with sourceMapUrl (it works much better on VM > > > side > > > > > > since > > > > > > > VM > > > > > > > > > has access to actual script source). > > > > > > > > > > > > > > > > We are currently rethinking how to interface with Chrome Devtools. > > I'd > > > > > > rather > > > > > > > > not expose yet another ad-hoc API in the JS part of the debugger > > that > > > > may > > > > > > > > eventually break. > > > > > > > > > > > > > > Thanks for information. It will be cool — not to reinvent yet > another > > > > > debugger > > > > > > > protocol, but use WIP. We are happy to use WIP and we don't have > > issues > > > > with > > > > > > it. > > > > > > > If possible, please inform me when it will be available to test > prior > > to > > > > > > > release. > > > > > > > > > > > > > > Bit I think, new WIP will be not implemented soon (several months), > > > right? > > > > > So, > > > > > > > until that, may be you can apply so simple patch? The problem is — > our > > > > > > solution > > > > > > > works in nodejs v4 (all events are exposed), but doesn't work in v5 > > (new > > > > > > version > > > > > > > of V8). > > > > > > > > > > > > toJSONProtocol is not used by Chromium. I'd be more comfortable > > > upstreaming > > > > > the > > > > > > changes you apply to it, if they are reasonable. And also, please > remove > > > the > > > > > > comment about JetBrains. V8 is not directly affiliated to JetBrains. > > > > > > > > > > >> I'd be more comfortable upstreaming the changes you apply to i > > > > > Our implementation — > https://gist.github.com/develar/6365b609dc94047bd9fb > > > But > > > > > only addition of sourceMapUrl field is reasonable. If logic is ok for > you > > > > (lines > > > > > 38-44 > > > > > > > > > > > > > > > https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts... > > > > > — > > > > > > > > > > > > > > > https://gist.github.com/develar/6365b609dc94047bd9fb#file-part-of-debugger-ts...), > > > > > I will prepare patch. > > > > > > > > sounds good. > > > > > > > > > > > > > > >> toJSONProtocol is not used by Chromium > > > > > Yep, I understand, it is the reason why WIP outperforms V8 protocol ;) > > > > > > > > V8's JSON debug protocol is only in place for legacy reasons. > > > > > > For some reasons I cannot add my RegExp to mirrors.js (patch > > > https://gist.github.com/develar/b8a9f1d61f5c65939871) — I got error > > > > > > Exception thrown during bootstrapping > > > Extension or internal compilation error: Unexpected token % in native > > mirrors.js > > > at line 40. > > > > > > It seems, preprocessor of this native file should be somehow modified. > > > > hm... I did not realize that your change was so involved and specific. Let's > go > > back to your original patch sans comment. > > Comment removed, BreakPoint is also exported. lgtm.
The CQ bit was checked by yangguo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477233002/40001
Description was changed from ========== Export BreakEvent and CompileEvent JetBrains debugger overrides BreakEvent/CompileEvent.toJSONProtocol implementation and it works in the previous version of V8 (nodejs v4) R=yangguo@chromium.org BUG= ========== to ========== Export BreakEvent and CompileEvent R=yangguo@chromium.org ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8934)
On 2015/12/14 14:55:33, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > v8_presubmit on tryserver.v8 (JOB_FAILED, > http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8934) I added myself to the AUTHORS to bypass presubmit check.
On 2015/12/15 10:55:34, develar wrote: > On 2015/12/14 14:55:33, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > v8_presubmit on tryserver.v8 (JOB_FAILED, > > http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8934) > > I added myself to the AUTHORS to bypass presubmit check. thanks.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org Link to the patchset: https://codereview.chromium.org/1477233002/#ps60001 (title: "add "Vladimir Krivosheev <develar@gmail.com>" to AUTHORS")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477233002/60001
On 2015/12/15 10:56:30, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/1477233002/60001 > View timeline at > https://chromium-cq-status.appspot.com/patch-timeline/1477233002/60001 Hm... could you move your name into alphabetically sorted order in AUTHORS?
On 2015/12/15 10:57:03, Yang wrote: > On 2015/12/15 10:56:30, commit-bot: I haz the power wrote: > > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/patch-status/1477233002/60001 > > View timeline at > > https://chromium-cq-status.appspot.com/patch-timeline/1477233002/60001 > > Hm... could you move your name into alphabetically sorted order in AUTHORS? Fixed, sorry, was not aware about it.
The CQ bit was checked by yangguo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org Link to the patchset: https://codereview.chromium.org/1477233002/#ps80001 (title: "move name "Vladimir Krivosheev <develar@gmail.com>" into alphabetically sorted order in AUTHORS")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477233002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477233002/80001
Message was sent while issue was closed.
Description was changed from ========== Export BreakEvent and CompileEvent R=yangguo@chromium.org ========== to ========== Export BreakEvent and CompileEvent R=yangguo@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Export BreakEvent and CompileEvent R=yangguo@chromium.org ========== to ========== Export BreakEvent and CompileEvent R=yangguo@chromium.org Committed: https://crrev.com/b201a7b93f35a3d66c319038d0f3419c7bd935cc Cr-Commit-Position: refs/heads/master@{#32861} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/b201a7b93f35a3d66c319038d0f3419c7bd935cc Cr-Commit-Position: refs/heads/master@{#32861} |
