chrome/browser/metrics/variations/variations_service.h - Issue 147723010: Expose a method in VariationsService to trigger a seed fetch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/variations_service.h

Issue 147723010: Expose a method in VariationsService to trigger a seed fetch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Alexei comments1 Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/variations/variations_request_scheduler_mobile_unittest.cc ('K') | « chrome/browser/metrics/variations/variations_request_scheduler_unittest.cc ('k') | chrome/browser/metrics/variations/variations_service.cc » ('j') | chrome/browser/metrics/variations/variations_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/variations/variations_service.h

diff --git a/chrome/browser/metrics/variations/variations_service.h b/chrome/browser/metrics/variations/variations_service.h

index 2ad70265263a69d70d7e0fe23fbbd4ab14478ade..6f5d3db2cc639ad2d31cbe88acd08c401e1319ad 100644

--- a/chrome/browser/metrics/variations/variations_service.h

+++ b/chrome/browser/metrics/variations/variations_service.h

@@ -53,6 +53,13 @@ class VariationsService

// static for test purposes.

static GURL GetVariationsServerURL(PrefService* local_prefs);

+ // Called when the application enters foreground. This may trigger a

+ // FetchVariationsSeed call.

+ // TODO(rkaplow): Handle this and the similar event in metrics_service by

+ // observing an 'OnAppEnterForeground' event instead of requiring the frontend

+ // code to notify each service individually.

+ void OnAppEnterForeground();

#if defined(OS_WIN)

// Starts syncing Google Update Variation IDs with the registry.

void StartGoogleUpdateRegistrySync();