Expose a method in VariationsService to trigger a seed fetch.

chrome/browser/metrics/variations/variations_request_scheduler.h

Index: chrome/browser/metrics/variations/variations_request_scheduler.h
diff --git a/chrome/browser/metrics/variations/variations_request_scheduler.h b/chrome/browser/metrics/variations/variations_request_scheduler.h
index beb3bbf6de55f6cd4a5865f754de2c5f7d0ef5da..7d811fc7a59d17cce0838eb8966c07cfb4f48c34 100644
--- a/chrome/browser/metrics/variations/variations_request_scheduler.h
+++ b/chrome/browser/metrics/variations/variations_request_scheduler.h
@@ -19,7 +19,7 @@ class VariationsRequestScheduler {
  public:
   virtual ~VariationsRequestScheduler();
 
-  // Starts the task on a schedule.
+  // Starts the task. This can be a repeated event or a one-off.
   virtual void Start();
 
   // Resets the scheduler if it is currently on a timer.
@@ -27,7 +27,11 @@ class VariationsRequestScheduler {
 
   // Schedules a fetch shortly, for example to re-try the initial request which
   // may have failed.
-  void ScheduleFetchShortly();
+  void ForceFetch();

[Alexei Svitkine (slow), 2014/02/13 16:13:08]

Why did you rename this? I found the previous name more intuitive (since Force
sounds like it may be immediately, whereas the other name suggests there will be
a delay).

[rkaplow, 2014/02/13 16:55:59]

Renaming was required when I had ScheduleFetch named based on what it was doing,
and it seemed the clearest way to differentiate the two. If we're switching the
other to OnApp then I can leave this as it was.

+
+  // Potentially fetch a new seed, depending on implementation. This may only
+  // fetch if there has not been one recently.
+  virtual void ScheduleFetch();

[Alexei Svitkine (slow), 2014/02/13 16:13:08]

Actually, I'd prefer if this was also named OnAppEnterForeground().

The idea is that in the eventual refactoring, we'd want this object to listen
for the events, and VariationsService to have no knowledge of it.

[rkaplow, 2014/02/13 16:55:59]

Done.

 
   // Factory method for this class.
   static VariationsRequestScheduler* Create(const base::Closure& task,
@@ -42,7 +46,7 @@ class VariationsRequestScheduler {
 
  private:
   FRIEND_TEST_ALL_PREFIXES(VariationsRequestSchedulerTest,
-                           ScheduleFetchShortly);
+                           ForceFetch);
 
   // The task scheduled by this class.
   base::Closure task_;