third_party/WebKit/Source/platform/heap/Visitor.h - Issue 1477213003: More switching to standard type traits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Visitor.h

Issue 1477213003: More switching to standard type traits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Excluded WTF::IsSubclass from the patch Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/Visitor.h

diff --git a/third_party/WebKit/Source/platform/heap/Visitor.h b/third_party/WebKit/Source/platform/heap/Visitor.h

index a32b7c931114d01a576559bd86a6a2c245a4a7e6..f7d877e801561176922bb5c4ac9eb66ffaf23cc7 100644

--- a/third_party/WebKit/Source/platform/heap/Visitor.h

+++ b/third_party/WebKit/Source/platform/heap/Visitor.h

@@ -187,7 +187,7 @@ public:

void trace(const T& t)

{

static_assert(sizeof(T), "T must be fully defined");

- if (WTF::IsPolymorphic<T>::value) {

+ if (std::is_polymorphic<T>::value) {

intptr_t vtable = *reinterpret_cast<const intptr_t*>(&t);

if (!vtable)

return;