third_party/WebKit/Source/platform/TraceEvent.h - Issue 1477213003: More switching to standard type traits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/TraceEvent.h

Issue 1477213003: More switching to standard type traits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use std::is_convertible in threading traits Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/TraceEvent.h

diff --git a/third_party/WebKit/Source/platform/TraceEvent.h b/third_party/WebKit/Source/platform/TraceEvent.h

index 20b6b7bc17caaa5fd2bf686401dbbb25811e5311..2bc6c4c102360c33b2e4732356216ddb8ca1c90a 100644

--- a/third_party/WebKit/Source/platform/TraceEvent.h

+++ b/third_party/WebKit/Source/platform/TraceEvent.h

@@ -384,7 +384,7 @@ template<typename T> struct ConvertableToTraceFormatTraits {

};

template<typename T> struct ConvertableToTraceFormatTraits<PassRefPtr<T>> {

- static const bool isConvertable = WTF::IsSubclass<T, TraceEvent::ConvertableToTraceFormat>::value;

+ static const bool isConvertable = std::is_convertible<T*, TraceEvent::ConvertableToTraceFormat*>::value;

static PassRefPtr<ConvertableToTraceFormat> moveFromIfConvertable(const PassRefPtr<T>& convertableToTraceFormat)

{

return convertableToTraceFormat;