Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1477213002: Mark PromiseRejectMessage::GetStackTrace as deprecated (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
Yang
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark PromiseRejectMessage::GetStackTrace as deprecated It's not used anywhere. BUG=none LOG=y R=yangguo@chromium.org Committed: https://crrev.com/b73118112a8e2b45386cfbf3d81c7253a5cdc93a Cr-Commit-Position: refs/heads/master@{#32348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M include/v8.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-11-26 14:55:10 UTC) #1
Yang
On 2015/11/26 14:55:10, jochen wrote: lgtm, but CL title is inaccurate. You are marking the ...
5 years ago (2015-11-26 14:57:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477213002/1
5 years ago (2015-11-26 14:58:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 16:01:54 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-26 16:02:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b73118112a8e2b45386cfbf3d81c7253a5cdc93a
Cr-Commit-Position: refs/heads/master@{#32348}

Powered by Google App Engine
This is Rietveld 408576698