src/arm/code-stubs-arm.cc - Issue 14772043: With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/code-stubs-arm.cc

Issue 14772043: With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/code-stubs-arm.cc

diff --git a/src/arm/code-stubs-arm.cc b/src/arm/code-stubs-arm.cc

index 98e5d8fecd9861b19fdc88156e63b38f516420bd..a7d2b81fce6a531bfee832dfb2408ae6b5c753ef 100644

--- a/src/arm/code-stubs-arm.cc

+++ b/src/arm/code-stubs-arm.cc

@@ -4790,6 +4790,7 @@ static void GenerateRecordCallTarget(MacroAssembler* masm) {

__ bind(&megamorphic);

__ LoadRoot(ip, Heap::kUndefinedValueRootIndex);

__ str(ip, FieldMemOperand(r2, JSGlobalPropertyCell::kValueOffset));

+ __ jmp(&done);

// An uninitialized cache is patched with the function or sentinel to

// indicate the ElementsKind if function is the Array constructor.

« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »