Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Side by Side Diff: test/mjsunit/allocation-site-info.js

Issue 14772043: With flag optimize-constructed-arrays on, ARM and MIPS suffered a performance degrade (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 10 matching lines...) Expand all
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax --smi-only-arrays --expose-gc 28 // Flags: --allow-natives-syntax --smi-only-arrays --expose-gc
29 // Flags: --track-allocation-sites --noalways-opt 29 // Flags: --track-allocation-sites --noalways-opt
30 30
31 // TODO(mvstanton): remove --nooptimize-constructed-arrays and enable
32 // the constructed array code below when the feature is turned on
33 // by default.
34
35 // Test element kind of objects. 31 // Test element kind of objects.
36 // Since --smi-only-arrays affects builtins, its default setting at compile 32 // Since --smi-only-arrays affects builtins, its default setting at compile
37 // time sticks if built with snapshot. If --smi-only-arrays is deactivated 33 // time sticks if built with snapshot. If --smi-only-arrays is deactivated
38 // by default, only a no-snapshot build actually has smi-only arrays enabled 34 // by default, only a no-snapshot build actually has smi-only arrays enabled
39 // in this test case. Depending on whether smi-only arrays are actually 35 // in this test case. Depending on whether smi-only arrays are actually
40 // enabled, this test takes the appropriate code path to check smi-only arrays. 36 // enabled, this test takes the appropriate code path to check smi-only arrays.
41 37
42 // support_smi_only_arrays = %HasFastSmiElements(new Array(1,2,3,4,5,6,7,8)); 38 // support_smi_only_arrays = %HasFastSmiElements(new Array(1,2,3,4,5,6,7,8));
43 support_smi_only_arrays = true; 39 support_smi_only_arrays = true;
44 optimize_constructed_arrays = false; 40 optimize_constructed_arrays = true;
45 41
46 if (support_smi_only_arrays) { 42 if (support_smi_only_arrays) {
47 print("Tests include smi-only arrays."); 43 print("Tests include smi-only arrays.");
48 } else { 44 } else {
49 print("Tests do NOT include smi-only arrays."); 45 print("Tests do NOT include smi-only arrays.");
50 } 46 }
51 47
52 if (optimize_constructed_arrays) { 48 if (optimize_constructed_arrays) {
53 print("Tests include constructed array optimizations."); 49 print("Tests include constructed array optimizations.");
54 } else { 50 } else {
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 295
300 var realmBArray = Realm.eval(realmB, "Array"); 296 var realmBArray = Realm.eval(realmB, "Array");
301 instanceof_check(Array); 297 instanceof_check(Array);
302 instanceof_check(realmBArray); 298 instanceof_check(realmBArray);
303 %OptimizeFunctionOnNextCall(instanceof_check); 299 %OptimizeFunctionOnNextCall(instanceof_check);
304 instanceof_check(Array); 300 instanceof_check(Array);
305 instanceof_check(realmBArray); 301 instanceof_check(realmBArray);
306 assertTrue(2 != %GetOptimizationStatus(instanceof_check)); 302 assertTrue(2 != %GetOptimizationStatus(instanceof_check));
307 } 303 }
308 } 304 }
OLDNEW
« no previous file with comments | « src/mips/code-stubs-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698