cc::OutputSurfaceClient::InitializeForGL

android_webview/browser/in_process_renderer/in_process_view_renderer.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/in_process_renderer/in_process_view_renderer.h"
 
 #include <android/bitmap.h>
 
 #include "android_webview/public/browser/draw_gl.h"
 #include "android_webview/public/browser/draw_sw.h"
@@ skipping 164 matching lines @@
   web_contents_->SetUserData(kUserDataKey, new UserData(this));
 }
 
 void InProcessViewRenderer::WebContentsGone() {
   web_contents_ = NULL;
 }
 
 bool InProcessViewRenderer::PrepareDrawGL(int x, int y) {
   // No harm in updating |hw_rendering_scroll_| even if we return false.
   hw_rendering_scroll_ = gfx::Point(x, y);
-  return attached_to_window_ && compositor_ && compositor_->IsHwReady() &&
-      !hardware_failed_;
+  return attached_to_window_ && compositor_ && !hardware_failed_;
 }
 
 void InProcessViewRenderer::DrawGL(AwDrawGLInfo* draw_info) {
   DCHECK(view_visible_);
 
   // We need to watch if the current Android context has changed and enforce
   // a clean-up in the compositor.
   EGLContext current_context = eglGetCurrentContext();
   if (!current_context) {
     LOG(WARNING) << "No current context attached. Skipping composite.";
     return;
   }
 
   if (attached_to_window_ && compositor_ && !hardware_initialized_) {
-    // TODO(boliu): Actually initialize the compositor GL path.
+    hardware_failed_ = !compositor_->InitializeHwDraw();
     hardware_initialized_ = true;

[joth, 2013/05/21 02:08:00]

lets rename these two memebers:
hardware_initialized_ => hardware_initialization_attempted_
hardware_failed_ => hardware_initialized_

hmmm that makes the logic in PrepareDrawGL more complicated.

How about a tristate? HwInitState {
  HWINIT_UNATTEMPTED,
  HWINIT_SUCCEEDED,
  HWINIT_FAILED
}

     egl_context_at_init_ = current_context;
+
+    if (hardware_failed_)
+      return;
   }
 

[joth, 2013/05/21 02:08:00]

guess we could DCHECK(!hardware_failed_) here

   if (draw_info->mode == AwDrawGLInfo::kModeProcess)
     return;
 
   if (egl_context_at_init_ != current_context) {
     // TODO(boliu): Handle context lost
   }
 
   // TODO(boliu): Make sure this is not called before compositor is initialized
   // and GL is ready. Then make this a DCHECK.
   if (!compositor_)
@@ skipping 206 matching lines @@
   // TODO(joth): BrowserViewRendererImpl had a bunch of logic for dpi and page
   // scale here. Determine what if any needs bringing over to this class.
   return CompositeSW(canvas);
 }
 
 bool InProcessViewRenderer::CompositeSW(SkCanvas* canvas) {
   return compositor_ && compositor_->DemandDrawSw(canvas);
 }
 
 }  // namespace android_webview