cc::OutputSurfaceClient::InitializeForGL

cc/trees/layer_tree_host_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_impl.h"
 
 #include <algorithm>
 
 #include "base/basictypes.h"
 #include "base/json/json_writer.h"
@@ skipping 1404 matching lines @@
 
   // Note: order is important here.
   renderer_.reset();
   tile_manager_.reset();
   resource_provider_.reset();
   output_surface_.reset();
 
   if (!output_surface->BindToClient(this))
     return false;
 
-  if (output_surface->capabilities().deferred_gl_initialization) {
+  return DoInitializeRenderer(output_surface.Pass(),
+                              false /* is_deffered_init */);
+}
+
+bool LayerTreeHostImpl::DoInitializeRenderer(
+    scoped_ptr<OutputSurface> output_surface,
+    bool is_deffered_init) {
+  if (output_surface->capabilities().deferred_gl_initialization &&
+      !is_deffered_init) {
     // TODO(joth): Defer creating the Renderer too, until GL is initialized.
     // See http://crbug.com/230197
     renderer_ = SoftwareRenderer::Create(this, output_surface.get(), NULL);

[piman, 2013/05/28 23:35:34]

I wasn't involved in the original CL, but like Dana I have serious reservation
wrt not having a resource_provider_ in the "deferred" mode.

It will crash on many things, e.g. if you need a render pass, if you have any
quad type beyond Picture or SolidColor etc.
OTOH you have no way of ensuring that invariant at this level - I'm not even
sure what your plan is wrt render pass limitation. So it will result in many
types of run-time checks, and it will be very very fragile.

I also see no test in this CL. They will be very much needed.

   } else {
     scoped_ptr<ResourceProvider> resource_provider = ResourceProvider::Create(
         output_surface.get(), settings_.highp_threshold_min);
     if (!resource_provider)
       return false;
 
     if (output_surface->capabilities().has_parent_compositor) {
       renderer_ = DelegatingRenderer::Create(this, output_surface.get(),
                                              resource_provider.get());
     } else if (output_surface->context3d()) {
@@ skipping 33 matching lines @@
 
   // See note in LayerTreeImpl::UpdateDrawProperties.  Renderer needs
   // to be initialized to get max texture size.
   active_tree_->set_needs_update_draw_properties();
   if (pending_tree_)
     pending_tree_->set_needs_update_draw_properties();
 
   return true;
 }
 
+bool LayerTreeHostImpl::InitializeForGL(
+    scoped_refptr<ContextProvider> offscreen_context_provider) {
+  DCHECK(output_surface_->capabilities().deferred_gl_initialization);
+  DCHECK(output_surface_->context3d());
+  bool success =
+      DoInitializeRenderer(output_surface_.Pass(), true /* is_deffered_init */);
+  client_->DidTryInitializeRendererOnImplThread(success,
+                                                offscreen_context_provider);
+  return success;
+}
+
 void LayerTreeHostImpl::SetViewportSize(gfx::Size device_viewport_size) {
   if (device_viewport_size == device_viewport_size_)
     return;
 
   if (pending_tree_ && device_viewport_size_ != device_viewport_size)
     active_tree_->SetViewportSizeInvalid();
 
   device_viewport_size_ = device_viewport_size;
 
   UpdateMaxScrollOffset();
@@ skipping 743 matching lines @@
 }
 
 void LayerTreeHostImpl::SetDebugState(const LayerTreeDebugState& debug_state) {
   if (debug_state_.continuous_painting != debug_state.continuous_painting)
     paint_time_counter_->ClearHistory();
 
   debug_state_ = debug_state;
 }
 
 }  // namespace cc