Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 14772003: Housekeeper should not fail when skia-autogen is reset (Closed)

Created:
7 years, 7 months ago by rmistry
Modified:
7 years, 7 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com, skiabot_google.com
Visibility:
Public.

Description

Housekeeper should not fail when skia-autogen is reset. Created to fix https://code.google.com/p/skia/issues/detail?id=1269 : UpdateDoxygen and UploadDoxygen steps fail when skia-autogen repository is reset. (SkipBuildbotRuns) R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=8935

Patch Set 1 #

Patch Set 2 : #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M tools/update-doxygen.sh View 1 2 chunks +20 lines, -2 lines 6 comments Download

Messages

Total messages: 7 (0 generated)
rmistry
7 years, 7 months ago (2013-05-01 12:06:30 UTC) #1
borenet
https://codereview.chromium.org/14772003/diff/2001/tools/update-doxygen.sh File tools/update-doxygen.sh (right): https://codereview.chromium.org/14772003/diff/2001/tools/update-doxygen.sh#newcode22 tools/update-doxygen.sh:22: mkdir docs Should you "svn add" docs here? I ...
7 years, 7 months ago (2013-05-01 12:10:38 UTC) #2
rmistry
https://codereview.chromium.org/14772003/diff/2001/tools/update-doxygen.sh File tools/update-doxygen.sh (right): https://codereview.chromium.org/14772003/diff/2001/tools/update-doxygen.sh#newcode22 tools/update-doxygen.sh:22: mkdir docs On 2013/05/01 12:10:39, borenet wrote: > Should ...
7 years, 7 months ago (2013-05-01 12:15:22 UTC) #3
borenet
Per our live discussion, I don't like that the behavior is different between running the ...
7 years, 7 months ago (2013-05-01 13:45:34 UTC) #4
rmistry
On 2013/05/01 13:45:34, borenet wrote: > Per our live discussion, I don't like that the ...
7 years, 7 months ago (2013-05-01 13:49:35 UTC) #5
rmistry
https://codereview.chromium.org/14772003/diff/2001/tools/update-doxygen.sh File tools/update-doxygen.sh (right): https://codereview.chromium.org/14772003/diff/2001/tools/update-doxygen.sh#newcode68 tools/update-doxygen.sh:68: NEWFILES=$(svn status | grep ^\? | awk '{print $2}') ...
7 years, 7 months ago (2013-05-01 13:49:39 UTC) #6
rmistry
7 years, 7 months ago (2013-05-01 14:47:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r8935 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698