Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1477133002: Enables opening an origin from password exceptions list ("Never save" list) with keyboard. (Closed)

Created:
5 years ago by kolos1
Modified:
5 years ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, vabr+watchlistpasswordmanager_chromium.org, arv+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enables opening an origin from password exceptions list ("Never save" list) with keyboard. BUG=560769 Committed: https://crrev.com/9cb8e2ec73001b3568c5cdf01252f52d55672b92 Cr-Commit-Position: refs/heads/master@{#362936}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M chrome/browser/resources/options/password_manager_list.js View 1 2 5 chunks +35 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kolos1
Hi Evan, Please review my changes. Best regards, Maxim
5 years ago (2015-11-26 09:43:11 UTC) #3
Evan Stade
lgtm with nit (applied there and elsewhere in this changelist) https://codereview.chromium.org/1477133002/diff/20001/chrome/browser/resources/options/password_manager_list.js File chrome/browser/resources/options/password_manager_list.js (right): https://codereview.chromium.org/1477133002/diff/20001/chrome/browser/resources/options/password_manager_list.js#newcode82 ...
5 years ago (2015-11-30 18:23:36 UTC) #4
kolos1
https://codereview.chromium.org/1477133002/diff/20001/chrome/browser/resources/options/password_manager_list.js File chrome/browser/resources/options/password_manager_list.js (right): https://codereview.chromium.org/1477133002/diff/20001/chrome/browser/resources/options/password_manager_list.js#newcode82 chrome/browser/resources/options/password_manager_list.js:82: deletableItem.handleFocus(); Thanks. Done.
5 years ago (2015-12-01 09:00:14 UTC) #5
kolos1
Hi Ivan, Just to double check, please confirm that changes look good to you. Thanks. ...
5 years ago (2015-12-02 12:36:04 UTC) #6
Evan Stade
yea, my lgtm still stands
5 years ago (2015-12-02 17:48:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477133002/40001
5 years ago (2015-12-03 08:28:00 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-03 09:08:20 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-03 09:09:11 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9cb8e2ec73001b3568c5cdf01252f52d55672b92
Cr-Commit-Position: refs/heads/master@{#362936}

Powered by Google App Engine
This is Rietveld 408576698