Issue 147713002: Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147713002: Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT(). (Closed)

Created:
6 years, 11 months ago by tfarina

Modified:
6 years, 11 months ago

Reviewers:
mtklein, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Unwrap GrRedBlackTree unit test and use REPORTER_ASSERT(). This fixes the mtklein's TODO in GrUnitTests.cpp. BUG=None TEST=out/Debug/tests R=mtklein@google.com, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=13208

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+184 lines, -178 lines)			Patch
M	gyp/tests.gyp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/gpu/GrRedBlackTree.h	View	2 chunks	+1 line, -171 lines	0 comments	Download
A	tests/GrRedBlackTreeTest.cpp	View	1 chunk	+180 lines, -0 lines	0 comments	Download
M	tests/GrUnitTests.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tfarina

Hi Mike, could you review this to me? I'm fine if you turn me down ...

6 years, 11 months ago (2014-01-25 18:42:50 UTC) #1

robertphillips

This is just moving the test to its own file and updating it a bit, ...

6 years, 11 months ago (2014-01-27 13:28:13 UTC) #3

tfarina

Committed patchset #1 manually as r13208 (presubmit successful).

6 years, 11 months ago (2014-01-27 21:40:28 UTC) #5

epoger

6 years, 11 months ago (2014-01-27 21:53:51 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/148653002/ by epoger@google.com.

The reason for reverting is: broke
http://108.170.217.252:10115/builders/Build-Mac10.8-Clang-x86_64-Release/buil...
and other builders:

GrRedBlackTreeTest.cpp:24:36: error: use of undeclared identifier 'xi'
.

Expand Messages | Collapse Messages