Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 1477123002: Rewrite doubleclick-crash.html layouttest with w3c testharness (Closed)

Created:
5 years ago by yoichio
Modified:
5 years ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The test confirms not crash. Thus use testharness on doubleclick-crash.html and remove unused expectations. BUG=539693 Committed: https://crrev.com/04c5f6b91f7ec47a4819419bc7ed739463035aa2 Cr-Commit-Position: refs/heads/master@{#361943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -129 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/selection/doubleclick-crash.html View 1 chunk +10 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/doubleclick-crash-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/doubleclick-crash-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/doubleclick-crash-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/doubleclick-crash-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/doubleclick-crash-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win-xp/editing/selection/doubleclick-crash-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/doubleclick-crash-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/doubleclick-crash-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/editing/selection/doubleclick-crash-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win7/editing/selection/doubleclick-crash-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yoichio
5 years ago (2015-11-27 02:22:03 UTC) #3
yosin_UTC9
lgtm
5 years ago (2015-11-27 02:24:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477123002/1
5 years ago (2015-11-27 02:24:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 02:29:39 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-27 02:31:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04c5f6b91f7ec47a4819419bc7ed739463035aa2
Cr-Commit-Position: refs/heads/master@{#361943}

Powered by Google App Engine
This is Rietveld 408576698