Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 14771017: Copy NaCl directory into trunk/platform_tools, adjust paths (Closed)

Created:
7 years, 7 months ago by borenet
Modified:
7 years, 7 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Copy NaCl directory into trunk/platform_tools, adjust paths (SkipBuildbotRuns) R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=9008

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M trunk/gyp/debugger.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M trunk/gyp/nacl.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M + trunk/platform_tools/nacl/SampleApp/SampleApp.nmf View 1 chunk +2 lines, -2 lines 0 comments Download
M + trunk/platform_tools/nacl/debugger/debugger.nmf View 1 chunk +2 lines, -2 lines 0 comments Download
M + trunk/platform_tools/nacl/nacl_make View 1 chunk +2 lines, -2 lines 0 comments Download
M + trunk/platform_tools/nacl/tests/tests.nmf View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
borenet
Is it expected that only the copied-and-modified files show up here?
7 years, 7 months ago (2013-05-03 17:56:00 UTC) #1
borenet
Patch set 2 adds gyp changes.
7 years, 7 months ago (2013-05-03 18:00:11 UTC) #2
djsollen
lgtm
7 years, 7 months ago (2013-05-03 19:52:50 UTC) #3
borenet
7 years, 7 months ago (2013-05-06 12:50:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r9008 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698