sdk/lib/io/secure_socket.dart - Issue 14771007: Always connect using HOST_NAME, but swicth on host source on secure upgrade, in secure_upgrade test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/secure_socket.dart

Issue 14771007: Always connect using HOST_NAME, but swicth on host source on secure upgrade, in secure_upgrade test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/io/secure_socket.dart

diff --git a/sdk/lib/io/secure_socket.dart b/sdk/lib/io/secure_socket.dart

index f75f7a7e2a6601581f8367c505ea642d27f4c1d5..4ed4da43e013afa5406be0d8fd28dc19d8439ec4 100644

--- a/sdk/lib/io/secure_socket.dart

+++ b/sdk/lib/io/secure_socket.dart

@@ -295,7 +295,7 @@ abstract class RawSecureSocket implements RawSocket {

socket.readEventsEnabled = false;

socket.writeEventsEnabled = false;

return _RawSecureSocket.connect(

- socket.remoteHost,

+ socket.address,

socket.remotePort,

certificateName,

is_server: true,

@@ -461,7 +461,7 @@ class _RawSecureSocket extends Stream<RawSocketEvent>

_socketSubscription.onDone(_doneHandler);

}

_connectPending = true;

- _secureFilter.connect(rawSocket.address.host,

+ _secureFilter.connect(address.host,

port,

is_server,

certificateName,

« no previous file with comments | « no previous file | tests/standalone/io/socket_upgrade_to_secure_test.dart » ('j') | no next file with comments »