src/ast/OWNERS - Issue 1477093003: Add more OWNER files

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/ast/OWNERS

Issue 1477093003: Add more OWNER files (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 set noparent	1 set noparent
	adamk 2015/11/30 19:01:06 Does an AST owners file even make much sense? I'm Does an AST owners file even make much sense? I'm not convinced one can make an interesting change in here without making changes across the code base: adding new nodes requires touching the compilers, modifying existing nodes would involve touching at least the parser and maybe a compiler too. Standalone Scope changes I could see, but I'd argue that scopes.cc and scopeinfo.cc just barely belong in this directory. If we do decide to keep it, I'd add littledan, since he's been doing lots of work here for harmony scoping and has plenty of experience in this area.
2	2

	3 adamk@chromium.org

3 bmeurer@chromium.org	4 bmeurer@chromium.org

4 mstarzinger@chromium.org	5 mstarzinger@chromium.org

5 oth@chromium.org	6 rossberg@chromium.org

6 rmcilroy@chromium.org	7

OLD	NEW

« no previous file with comments | « no previous file | src/js/OWNERS » ('j') | src/js/OWNERS » ('J')