Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1477093002: Switch CSSVariableResolver to use CSSParserTokenRange internally. (Closed)

Created:
5 years ago by shans
Modified:
5 years ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch CSSVariableResolver to use CSSParserTokenRange internally. BUG=465126 Committed: https://crrev.com/7ec1eb82ba5261e1f1eb9df4b202c67cbde1f690 Cr-Commit-Position: refs/heads/master@{#361868}

Patch Set 1 #

Total comments: 10

Patch Set 2 : review comments #

Patch Set 3 : For science! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -81 lines) Patch
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 1 2 3 chunks +33 lines, -79 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
shans
5 years ago (2015-11-26 04:04:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477093002/1
5 years ago (2015-11-26 04:05:34 UTC) #4
Timothy Loh
This is pretty good, some comments below on how to have less loops ;-) I ...
5 years ago (2015-11-26 04:55:31 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-26 05:35:39 UTC) #8
shans
https://codereview.chromium.org/1477093002/diff/1/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp File third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp (right): https://codereview.chromium.org/1477093002/diff/1/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp#newcode30 third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp:30: while ((token = &varReference.consume())->type() != IdentToken) { } On ...
5 years ago (2015-11-26 05:36:41 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477093002/20001
5 years ago (2015-11-26 05:36:58 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477093002/40001
5 years ago (2015-11-26 05:43:05 UTC) #13
Timothy Loh
lgtm
5 years ago (2015-11-26 05:43:46 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-26 07:16:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477093002/40001
5 years ago (2015-11-26 11:00:00 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-26 11:04:22 UTC) #19
commit-bot: I haz the power
5 years ago (2015-11-26 11:05:18 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7ec1eb82ba5261e1f1eb9df4b202c67cbde1f690
Cr-Commit-Position: refs/heads/master@{#361868}

Powered by Google App Engine
This is Rietveld 408576698