MIPS: [turbofan] Implement Float32Round(TiesEven|RoundUp|RoundDown|Truncate).

MIPS: [turbofan] Implement Float32Round(TiesEven|RoundUp|RoundDown|Truncate).

TEST=
BUG=

Committed: https://crrev.com/7a918fb6e7cae37761e7a323b6bbcf940d29fe8d
Cr-Commit-Position: refs/heads/master@{#32347}

[dusan.milosavljevic, 2015-11-26 01:49:52]

dusan.m.milosavljevic@gmail.com changed reviewers:
+ ahaas@chromium.org, akos.palfi@imgtec.com, balazs.kilvady@imgtec.com,
paul.lind@imgtec.com, titzer@chromium.org

[dusan.milosavljevic, 2015-11-26 01:49:52]

PTAL.

[titzer, 2015-11-26 08:43:03]

https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
File src/compiler/mips64/code-generator-mips64.cc (right):

https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
src/compiler/mips64/code-generator-mips64.cc:240: class OutOfLineTruncate32
final : public OutOfLineRound32 {
Looks like the out of line code is exactly the same for all four cases, so maybe
we can just drop these extra classes?

[dusan.milosavljevic, 2015-11-26 12:52:37]

https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
File src/compiler/mips64/code-generator-mips64.cc (right):

https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
src/compiler/mips64/code-generator-mips64.cc:240: class OutOfLineTruncate32
final : public OutOfLineRound32 {
Right, too much duplicated code.

https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
src/compiler/mips64/code-generator-mips64.cc:240: class OutOfLineTruncate32
final : public OutOfLineRound32 {
On 2015/11/26 08:43:03, titzer wrote:
> Looks like the out of line code is exactly the same for all four cases, so
maybe
> we can just drop these extra classes?

Done.

[titzer, 2015-11-26 12:54:53]

On 2015/11/26 12:52:37, dusan.milosavljevic wrote:
>
https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
> File src/compiler/mips64/code-generator-mips64.cc (right):
> 
>
https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
> src/compiler/mips64/code-generator-mips64.cc:240: class OutOfLineTruncate32
> final : public OutOfLineRound32 {
> Right, too much duplicated code.
> 
>
https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
> src/compiler/mips64/code-generator-mips64.cc:240: class OutOfLineTruncate32
> final : public OutOfLineRound32 {
> On 2015/11/26 08:43:03, titzer wrote:
> > Looks like the out of line code is exactly the same for all four cases, so
> maybe
> > we can just drop these extra classes?
> 
> Done.

Thanks. Can you do the same in MIPS 32?

[dusan.milosavljevic, 2015-11-26 14:15:37]

On 2015/11/26 12:54:53, titzer wrote:
> On 2015/11/26 12:52:37, dusan.milosavljevic wrote:
> >
>
https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
> > File src/compiler/mips64/code-generator-mips64.cc (right):
> > 
> >
>
https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
> > src/compiler/mips64/code-generator-mips64.cc:240: class OutOfLineTruncate32
> > final : public OutOfLineRound32 {
> > Right, too much duplicated code.
> > 
> >
>
https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
> > src/compiler/mips64/code-generator-mips64.cc:240: class OutOfLineTruncate32
> > final : public OutOfLineRound32 {
> > On 2015/11/26 08:43:03, titzer wrote:
> > > Looks like the out of line code is exactly the same for all four cases, so
> > maybe
> > > we can just drop these extra classes?
> > 
> > Done.
> 
> Thanks. Can you do the same in MIPS 32?

Done. I thought I did it.

[titzer, 2015-11-26 14:22:55]

On 2015/11/26 14:15:37, dusan.milosavljevic wrote:
> On 2015/11/26 12:54:53, titzer wrote:
> > On 2015/11/26 12:52:37, dusan.milosavljevic wrote:
> > >
> >
>
https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
> > > File src/compiler/mips64/code-generator-mips64.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
> > > src/compiler/mips64/code-generator-mips64.cc:240: class
OutOfLineTruncate32
> > > final : public OutOfLineRound32 {
> > > Right, too much duplicated code.
> > > 
> > >
> >
>
https://codereview.chromium.org/1477043004/diff/1/src/compiler/mips64/code-ge...
> > > src/compiler/mips64/code-generator-mips64.cc:240: class
OutOfLineTruncate32
> > > final : public OutOfLineRound32 {
> > > On 2015/11/26 08:43:03, titzer wrote:
> > > > Looks like the out of line code is exactly the same for all four cases,
so
> > > maybe
> > > > we can just drop these extra classes?
> > > 
> > > Done.
> > 
> > Thanks. Can you do the same in MIPS 32?
> 
> Done. I thought I did it.

lgtm

[dusan.milosavljevic, 2015-11-26 15:12:09]

The CQ bit was checked by dusan.m.milosavljevic@gmail.com

[dusan.milosavljevic, 2015-11-26 15:12:09]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1477043004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-11-26 15:12:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477043004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477043004/80001

[commit-bot: I haz the power, 2015-11-26 15:55:44]

Committed patchset #5 (id:80001)

[Paul.Lind_imgtec.com, 2015-11-26 15:55:53]

I am out of the office from Thursday Nov 19 through Sunday Nov 29, 2015.

I will have occasional email access during this time. There may be a multiple
day delay in my response.

Thanks,

Paul

[commit-bot: I haz the power, 2015-11-26 15:56:15]

Description was changed from

==========
MIPS: [turbofan] Implement Float32Round(TiesEven|RoundUp|RoundDown|Truncate).

TEST=
BUG=
==========

to

==========
MIPS: [turbofan] Implement Float32Round(TiesEven|RoundUp|RoundDown|Truncate).

TEST=
BUG=

Committed: https://crrev.com/7a918fb6e7cae37761e7a323b6bbcf940d29fe8d
Cr-Commit-Position: refs/heads/master@{#32347}
==========

[commit-bot: I haz the power, 2015-11-26 15:56:15]

Patchset 5 (id:??) landed as
https://crrev.com/7a918fb6e7cae37761e7a323b6bbcf940d29fe8d
Cr-Commit-Position: refs/heads/master@{#32347}