third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp - Issue 1477043003: Handle aria-owns and presentational children in AX name calc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp

Issue 1477043003: Handle aria-owns and presentational children in AX name calc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@garaventa_visibility_hidden

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/name-calc-presentational.html ('k') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp b/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp

index 270b05b543e51a561e086f4c8f7927202563568f..46f79e649432510fc7588a1bd21e343131719de2 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXARIAGrid.cpp

@@ -94,7 +94,7 @@ void AXARIAGrid::addChildren()

return;

HeapVector<Member<AXObject>> children;

- for (AXObject* child = rawFirstChild(); child; child = child->rawFirstSibling())

+ for (AXObject* child = rawFirstChild(); child; child = child->rawNextSibling())

children.append(child);

computeAriaOwnsChildren(children);