Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObject.h

Issue 1477043003: Handle aria-owns and presentational children in AX name calc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@garaventa_visibility_hidden
Patch Set: Better solution to handle both aria-owns and role=presentation in name calc Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXObject.h
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObject.h b/third_party/WebKit/Source/modules/accessibility/AXObject.h
index 94ad5bf8baef59d5913eb3e0f42ec64e3cb3da83..eb4b4d90b6c42f76a772d17c6158292bc92014c0 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObject.h
+++ b/third_party/WebKit/Source/modules/accessibility/AXObject.h
@@ -694,9 +694,10 @@ public:
// exposed by one of the two functions above.
virtual String placeholder(AXNameFrom, AXDescriptionFrom) const { return String(); }
- // Internal function used by name and description, above.
+ // Internal functions used by name and description, above.
typedef HeapHashSet<Member<const AXObject>> AXObjectSet;
virtual String textAlternative(bool recursive, bool inAriaLabelledByTraversal, AXObjectSet& visited, AXNameFrom& nameFrom, AXRelatedObjectVector* relatedObjects, NameSources* nameSources) const { return String(); }
+ virtual String textFromDescendants(AXObjectSet& visited, bool recursive) const { return String(); }
// Returns result of Accessible Name Calculation algorithm.
// This is a simpler high-level interface to |name| used by Inspector.
@@ -831,7 +832,7 @@ public:
// Low-level accessibility tree exploration, only for use within the accessibility module.
virtual AXObject* rawFirstChild() const { return 0; }
- virtual AXObject* rawFirstSibling() const { return 0; }
+ virtual AXObject* rawNextSibling() const { return 0; }
AXObject* firstAccessibleObjectFromNode(const Node*);
virtual void addChildren() { }
virtual bool canHaveChildren() const { return true; }

Powered by Google App Engine
This is Rietveld 408576698