third_party/WebKit/Source/core/html/HTMLMediaElement.cpp - Issue 1477023003: Refactor the Heap into ThreadHeap to prepare for per thread heaps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 1477023003: Refactor the Heap into ThreadHeap to prepare for per thread heaps Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp ('k') | third_party/WebKit/Source/core/svg/SVGElementRareData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

index 9cf088ea4a43868bb36da0181b2db08f23d4ea81..09320162f9f14a78fa413db514921c8b4172c7f8 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

@@ -442,7 +442,7 @@ void HTMLMediaElement::dispose()

// If the MediaSource object survived, notify that the media element

// didn't.

- if (Heap::isHeapObjectAlive(m_mediaSource))

+ if (ThreadHeap::isHeapObjectAlive(m_mediaSource))

closeMediaSource();

// Oilpan: the player must be released, but the player object

@@ -3753,7 +3753,7 @@ void HTMLMediaElement::rejectPlayPromises(ExceptionCode code, const String& mess

void HTMLMediaElement::clearWeakMembers(Visitor* visitor)

{

- if (!Heap::isHeapObjectAlive(m_audioSourceNode))

+ if (!ThreadHeap::isHeapObjectAlive(m_audioSourceNode))

getAudioSourceProvider().setClient(nullptr);

}