third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp - Issue 1477023003: Refactor the Heap into ThreadHeap to prepare for per thread heaps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

Issue 1477023003: Refactor the Heap into ThreadHeap to prepare for per thread heaps Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp ('k') | third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

diff --git a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

index 1e8a73b8c35220a1329377cd0d2856c6fe9192d7..e5bff0a916748460c58aaebd0554df6ede11e869 100644

--- a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

+++ b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp

@@ -255,9 +255,9 @@ void EventHandlerRegistry::clearWeakMembers(Visitor* visitor)

for (const auto& eventTarget : *targets) {

Node* node = eventTarget.key->toNode();

LocalDOMWindow* window = eventTarget.key->toDOMWindow();

- if (node && !Heap::isHeapObjectAlive(node)) {

+ if (node && !ThreadHeap::isHeapObjectAlive(node)) {

deadTargets.append(node);

- } else if (window && !Heap::isHeapObjectAlive(window)) {

+ } else if (window && !ThreadHeap::isHeapObjectAlive(window)) {

deadTargets.append(window);

}