Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: third_party/WebKit/Source/platform/heap/PagePool.cpp

Issue 1477023003: Refactor the Heap into ThreadHeap to prepare for per thread heaps Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactored Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/PagePool.cpp
diff --git a/third_party/WebKit/Source/platform/heap/PagePool.cpp b/third_party/WebKit/Source/platform/heap/PagePool.cpp
index 9bda5c0d1eb8983ef3ff5e744cb9a90547385e20..c7128b57673136a181f414cbb7a9368f33ec8150 100644
--- a/third_party/WebKit/Source/platform/heap/PagePool.cpp
+++ b/third_party/WebKit/Source/platform/heap/PagePool.cpp
@@ -80,8 +80,7 @@ void OrphanedPagePool::decommitOrphanedPages()
#if ENABLE(ASSERT)
// No locking needed as all threads are at safepoints at this point in time.
- for (ThreadState* state : ThreadState::attachedThreads())
- ASSERT(state->isAtSafePoint());
+ ASSERT(ThreadState::mainThreadState()->gcGroup()->isParked());
haraken 2016/01/28 15:52:50 isParked => isAtSafePoint Note that "safe point"
keishi 2016/02/29 06:02:33 Done.
#endif
for (int index = 0; index < BlinkGC::NumberOfHeaps; ++index) {
@@ -101,7 +100,7 @@ void OrphanedPagePool::decommitOrphanedPages()
} else {
page->~BasePage();
clearMemory(memory);
- Heap::freePagePool()->addFreePage(index, memory);
+ ThreadState::current()->gcGroup()->freePagePool()->addFreePage(index, memory);
}
PoolEntry* deadEntry = entry;

Powered by Google App Engine
This is Rietveld 408576698