Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp

Issue 1477023003: Refactor the Heap into ThreadHeap to prepare for per thread heaps Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactored Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
diff --git a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
index 6f4f4e723f48ab675ab24bb7c2c11af92c8b974a..17fd25c0580bcfecb6d969e94c61f2499e4ab987 100644
--- a/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
+++ b/third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.cpp
@@ -18,14 +18,14 @@ void dumpMemoryTotals(blink::WebProcessMemoryDump* memoryDump)
{
String dumpName = String::format("blink_gc");
WebMemoryAllocatorDump* allocatorDump = memoryDump->createMemoryAllocatorDump(dumpName);
- allocatorDump->addScalar("size", "bytes", Heap::allocatedSpace());
+ allocatorDump->addScalar("size", "bytes", ThreadState::current()->gcGroup()->heapStats().allocatedSpace());
haraken 2016/01/28 15:52:48 I think allocatedSpace should be a member of Heap,
keishi 2016/02/29 06:02:32 Used Heap::totalAllocatedSpace
dumpName.append("/allocated_objects");
WebMemoryAllocatorDump* objectsDump = memoryDump->createMemoryAllocatorDump(dumpName);
// Heap::markedObjectSize() can be underestimated if we're still in the
// process of lazy sweeping.
- objectsDump->addScalar("size", "bytes", Heap::allocatedObjectSize() + Heap::markedObjectSize());
+ objectsDump->addScalar("size", "bytes", Heap::totalAllocatedObjectSize() + Heap::totalMarkedObjectSize());
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698