third_party/WebKit/Source/core/dom/CompositorProxy.cpp - Issue 1477023003: Refactor the Heap into ThreadHeap to prepare for per thread heaps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/CompositorProxy.cpp

Issue 1477023003: Refactor the Heap into ThreadHeap to prepare for per thread heaps Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h ('K') | « third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h ('k') | third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp » ('j') | third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/CompositorProxy.cpp

diff --git a/third_party/WebKit/Source/core/dom/CompositorProxy.cpp b/third_party/WebKit/Source/core/dom/CompositorProxy.cpp

index f45d7ccd873781ab03c0e2647bde0a0d21b72021..93f02995ce06e6e885f89f92ea040fe537bf0179 100644

--- a/third_party/WebKit/Source/core/dom/CompositorProxy.cpp

+++ b/third_party/WebKit/Source/core/dom/CompositorProxy.cpp

@@ -216,6 +216,7 @@ void CompositorProxy::setScrollTop(double scrollTop, ExceptionState& exceptionSt

void CompositorProxy::setTransform(DOMMatrix* transform, ExceptionState& exceptionState)

{

+ ASSERT(ThreadState::forObject(transform) == ThreadState::forObject(this));

haraken 2016/01/07 08:06:21 Is this useful?

if (raiseExceptionIfMutationNotAllowed(exceptionState))

return;

if (raiseExceptionIfNotMutable(static_cast<uint32_t>(WebCompositorMutablePropertyTransform), exceptionState))