third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h - Issue 1477023003: Refactor the Heap into ThreadHeap to prepare for per thread heaps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h

Issue 1477023003: Refactor the Heap into ThreadHeap to prepare for per thread heaps Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webdatabase/DatabaseContext.cpp ('k') | third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp » ('j') | third_party/WebKit/Source/platform/heap/Heap.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h

diff --git a/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h b/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h

index b1760161cd343e62f215aa9023209313f3b4ca2c..947428b325e376d7ad0340240f09e1c8dee4055f 100644

--- a/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h

+++ b/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h

@@ -44,6 +44,7 @@

namespace blink {

+// DatabaseTask can be created from main thread and database thread.

class DatabaseTask {

WTF_MAKE_NONCOPYABLE(DatabaseTask); USING_FAST_MALLOC(DatabaseTask);

public:

@@ -63,7 +64,7 @@ private:

virtual void doPerformTask() = 0;

virtual void taskCancelled() { }

- CrossThreadPersistent<Database> m_database;

+ XThreadPersistent<Database> m_database;

TaskSynchronizer* m_synchronizer;

#if !LOG_DISABLED

@@ -130,7 +131,7 @@ private:

const char* debugTaskName() const override;

#endif

- CrossThreadPersistent<SQLTransactionBackend> m_transaction;

+ XThreadPersistent<SQLTransactionBackend> m_transaction;

};

class Database::DatabaseTableNamesTask final : public DatabaseTask {