Deprecate Promise::Chain from V8 APIs

Deprecate Promise::Chain from V8 APIs

The Promise::Chain logic is moved to a helper function to avoid
a violation of deprecated function usage.

R=rossberg,jochen
BUG=v8:3237
LOG=Y

Committed: https://crrev.com/91e1b9f67b20d4d26c0297704e3216912dd4011b
Cr-Commit-Position: refs/heads/master@{#32670}

[Dan Ehrenberg, 2015-11-25 20:52:22]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 20:52:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477023002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477023002/1

[Dan Ehrenberg, 2015-11-25 20:53:23]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-25 20:53:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477023002/20001

[commit-bot: I haz the power, 2015-11-25 21:02:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 21:02:38]

Dry run: Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[Dan Ehrenberg, 2015-11-25 21:48:51]

Based on this trybot failure, looks like I have to wait for a release to go by
which removes the other one, and then remove this one. Is that right?

[jochen (gone - plz use gerrit), 2015-11-26 13:24:06]

just pull Chain out into a helper function and invoke that from the both
Promise::Chain variants

[Dan Ehrenberg, 2015-12-04 21:00:16]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 21:00:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477023002/20001

[Dan Ehrenberg, 2015-12-04 21:01:01]

On 2015/11/26 at 13:24:06, jochen wrote:
> just pull Chain out into a helper function and invoke that from the both
Promise::Chain variants

Done, but compilation seems to still fail for some reason. I don't quite
understand it yet.

In file included from ../../third_party/skia/include/core/SkRefCnt.h:128:
../../skia/config/sk_ref_cnt_ext_debug.h:17:3: error: [chromium-style] Complex
constructor has an inlined body.
  SkRefCnt() : flags_(0) {}
  ^
../../skia/config/sk_ref_cnt_ext_debug.h:15:1: error: [chromium-style] Complex
class/struct needs an explicit out-of-line destructor.
class SK_API SkRefCnt : public SkRefCntBase {
^
2 errors generated.

[commit-bot: I haz the power, 2015-12-04 21:01:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 21:01:22]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/12751)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11043)
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/11652)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8562)

[Dan Ehrenberg, 2015-12-04 21:01:49]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 21:01:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477023002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477023002/40001

[Dan Ehrenberg, 2015-12-04 21:02:16]

Description was changed from

==========
Deprecate Promise::Chain from V8 APIs

Because it will take a full release cycle to remove an API like this,
this patch installs promise_chain to the context regardless of whether
the --promise_extra flag is passed. This way, we could unship
Promise.prototype.chain while leaving it in the API for a bit longer.

R=rossberg,jochen
BUG=v8:3237
LOG=Y
==========

to

==========
Deprecate Promise::Chain from V8 APIs

The Promise::Chain logic is moved to a helper function to avoid
a violation of deprecated function usage.


R=rossberg,jochen
BUG=v8:3237
LOG=Y
==========

[commit-bot: I haz the power, 2015-12-04 21:04:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 21:04:30]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8564)

[Dan Ehrenberg, 2015-12-04 21:06:44]

On 2015/12/04 at 21:01:01, Dan Ehrenberg wrote:
> On 2015/11/26 at 13:24:06, jochen wrote:
> > just pull Chain out into a helper function and invoke that from the both
Promise::Chain variants
> 
> Done, but compilation seems to still fail for some reason. I don't quite
understand it yet.
> 
> In file included from ../../third_party/skia/include/core/SkRefCnt.h:128:
> ../../skia/config/sk_ref_cnt_ext_debug.h:17:3: error: [chromium-style] Complex
constructor has an inlined body.
>   SkRefCnt() : flags_(0) {}
>   ^
> ../../skia/config/sk_ref_cnt_ext_debug.h:15:1: error: [chromium-style] Complex
class/struct needs an explicit out-of-line destructor.
> class SK_API SkRefCnt : public SkRefCntBase {
> ^
> 2 errors generated.

Sorry, please ignore that update; working on a fix for the issue.

[Dan Ehrenberg, 2015-12-04 21:31:44]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[Dan Ehrenberg, 2015-12-04 21:31:57]

Description was changed from

==========
Deprecate Promise::Chain from V8 APIs

The Promise::Chain logic is moved to a helper function to avoid
a violation of deprecated function usage.


R=rossberg,jochen
BUG=v8:3237
LOG=Y
==========

to

==========
Deprecate Promise::Chain from V8 APIs

The Promise::Chain logic is moved to a helper function to avoid
a violation of deprecated function usage. Also fixed a number of
old lint errors.


R=rossberg,jochen
BUG=v8:3237
LOG=Y
==========

[commit-bot: I haz the power, 2015-12-04 21:32:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477023002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477023002/60001

[commit-bot: I haz the power, 2015-12-04 21:36:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 21:36:50]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8565)

[Dan Ehrenberg, 2015-12-04 21:43:05]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 21:43:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477023002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477023002/80001

[commit-bot: I haz the power, 2015-12-04 21:45:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 21:45:28]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8568)

[Dan Ehrenberg, 2015-12-04 21:47:51]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-04 21:47:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477023002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477023002/100001

[commit-bot: I haz the power, 2015-12-04 23:37:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 23:37:52]

Dry run: This issue passed the CQ dry run.

[Dan Ehrenberg, 2015-12-04 23:42:38]

PTAL

[jochen (gone - plz use gerrit), 2015-12-07 15:39:54]

lgtm with comment addressed

https://codereview.chromium.org/1477023002/diff/100001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1477023002/diff/100001/src/api.cc#newcode889
src/api.cc:889: DCHECK_LT(offset, length());
could you please move the unrelated refactoring to a separate CL?

[Dan Ehrenberg, 2015-12-07 18:57:54]

https://codereview.chromium.org/1477023002/diff/100001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1477023002/diff/100001/src/api.cc#newcode889
src/api.cc:889: DCHECK_LT(offset, length());
On 2015/12/07 at 15:39:54, jochen wrote:
> could you please move the unrelated refactoring to a separate CL?

It seems like the lint checking recently got more strict. I'll have to do this
other lint fix patch before the deprecation one goes in. I'll get back to you
with that in a few days.

[Dan Ehrenberg, 2015-12-08 01:14:28]

Description was changed from

==========
Deprecate Promise::Chain from V8 APIs

The Promise::Chain logic is moved to a helper function to avoid
a violation of deprecated function usage. Also fixed a number of
old lint errors.


R=rossberg,jochen
BUG=v8:3237
LOG=Y
==========

to

==========
Deprecate Promise::Chain from V8 APIs

The Promise::Chain logic is moved to a helper function to avoid
a violation of deprecated function usage.

R=rossberg,jochen
BUG=v8:3237
LOG=Y
==========

[Dan Ehrenberg, 2015-12-08 01:14:34]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2015-12-08 01:14:34]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1477023002/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2015-12-08 01:14:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1477023002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1477023002/120001

[commit-bot: I haz the power, 2015-12-08 02:28:48]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-12-08 02:29:44]

Description was changed from

==========
Deprecate Promise::Chain from V8 APIs

The Promise::Chain logic is moved to a helper function to avoid
a violation of deprecated function usage.

R=rossberg,jochen
BUG=v8:3237
LOG=Y
==========

to

==========
Deprecate Promise::Chain from V8 APIs

The Promise::Chain logic is moved to a helper function to avoid
a violation of deprecated function usage.

R=rossberg,jochen
BUG=v8:3237
LOG=Y

Committed: https://crrev.com/91e1b9f67b20d4d26c0297704e3216912dd4011b
Cr-Commit-Position: refs/heads/master@{#32670}
==========

[commit-bot: I haz the power, 2015-12-08 02:29:45]

Patchset 7 (id:??) landed as
https://crrev.com/91e1b9f67b20d4d26c0297704e3216912dd4011b
Cr-Commit-Position: refs/heads/master@{#32670}