Issue 14770005: SkOpSegment.cpp gcc 4.7 build failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14770005: SkOpSegment.cpp gcc 4.7 build failure. (Closed)

Created:
7 years, 7 months ago by fmalita_google_do_not_use

Modified:
7 years, 7 months ago

Reviewers:
caryclark

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

SkOpSegment.cpp gcc 4.7 build failure. SkOpSegment.cpp:2240:5: error: ordered comparison of pointer with integer zero Caught by gcc 4.7 -Werror=extra. R=caryclark@google.com Committed: https://code.google.com/p/skia/source/detail?r=8940

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pathops/SkOpSegment.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

caryclark

lgtm Good catch. I was stepping though this function today and looking at each line ...

7 years, 7 months ago (2013-05-01 16:12:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@google.com/14770005/1

7 years, 7 months ago (2013-05-01 16:22:02 UTC) #3

fmalita_google_do_not_use

7 years, 7 months ago (2013-05-01 20:35:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r8940 (presubmit successful).