Issue 14769008: Fix mmap region iteration while no regions are recorded.

Issue 14769008: Fix mmap region iteration while no regions are recorded. (Closed)

Created:
7 years, 7 months ago by Dai Mikurube (NOT FULLTIME)

Modified:
7 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, dmikurube+memory_chromium.org, bulach

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix mmap region iteration while no regions are recorded. If no mmap regions are recorded, iteration failed since the RegionSet (std::set) object is not initialized. BUG=162208 R=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198878

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -10 lines)			Patch
M	third_party/tcmalloc/chromium/src/deep-heap-profile.cc	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	third_party/tcmalloc/chromium/src/memory_region_map.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/tcmalloc/chromium/src/memory_region_map.cc	View	1 2	3 chunks	+13 lines, -8 lines	0 comments	Download

Total messages: 6 (0 generated)

Dai Mikurube (NOT FULLTIME)

Sorry for many review request. It's not time-sensitive, too. Could you take a look when ...

7 years, 7 months ago (2013-05-07 10:51:32 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/14769008/5001

7 years, 7 months ago (2013-05-07 23:02:30 UTC) #4

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 7 months ago (2013-05-08 00:14:56 UTC) #5

Dai Mikurube (NOT FULLTIME)

7 years, 7 months ago (2013-05-08 12:01:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r198878 (presubmit successful).