Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1476893004: Remove the presubmit warning when changing code in third_party/mojo/ (Closed)

Created:
5 years ago by danakj
Modified:
5 years ago
CC:
chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the presubmit warning when changing code in third_party/mojo/ This code is part of the chromium tree, not pulled in by DEPS. So we should let people change the code freely. Currently every time you change this code, a presubmit warning is given. Let's not do that. R=jam, jochen, sky Committed: https://crrev.com/b1423c53bd64c7865d730624038705d940fdac1e Cr-Commit-Position: refs/heads/master@{#361745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/PRESUBMIT.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
danakj
5 years ago (2015-11-25 20:00:28 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476893004/1
5 years ago (2015-11-25 20:01:16 UTC) #3
sky
LGTM
5 years ago (2015-11-25 20:58:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476893004/1
5 years ago (2015-11-25 21:07:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 22:10:20 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-25 22:12:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1423c53bd64c7865d730624038705d940fdac1e
Cr-Commit-Position: refs/heads/master@{#361745}

Powered by Google App Engine
This is Rietveld 408576698