Chromium Code Reviews| Index: third_party/WebKit/Source/bindings/scripts/v8_methods.py |
| diff --git a/third_party/WebKit/Source/bindings/scripts/v8_methods.py b/third_party/WebKit/Source/bindings/scripts/v8_methods.py |
| index 3ac9276e64e257883ae9121952e15ee58f51fb24..214c12c250c405a4f07772c127856eeb6ed0cb5f 100644 |
| --- a/third_party/WebKit/Source/bindings/scripts/v8_methods.py |
| +++ b/third_party/WebKit/Source/bindings/scripts/v8_methods.py |
| @@ -120,10 +120,13 @@ def method_context(interface, method, is_visible=True): |
| if 'LenientThis' in extended_attributes: |
| raise Exception('[LenientThis] is not supported for operations.') |
| + argument_contexts = [ |
| + argument_context(interface, method, argument, index, is_visible=is_visible) |
| + for index, argument in enumerate(arguments)] |
| + |
| return { |
| 'activity_logging_world_list': v8_utilities.activity_logging_world_list(method), # [ActivityLogging] |
| - 'arguments': [argument_context(interface, method, argument, index, is_visible=is_visible) |
| - for index, argument in enumerate(arguments)], |
| + 'arguments': argument_contexts, |
| 'argument_declarations_for_private_script': |
| argument_declarations_for_private_script(interface, method), |
| 'conditional_string': v8_utilities.conditional_string(method), |
| @@ -148,6 +151,12 @@ def method_context(interface, method, is_visible=True): |
| any(argument for argument in arguments |
| if (argument.idl_type.name == 'SerializedScriptValue' or |
| argument_conversion_needs_exception_state(method, argument))), |
| + 'has_optional_argument_without_default_value': |
| + any(True for argument_context in argument_contexts |
|
bashi
2015/11/26 23:37:18
Can we have a helper function for |has_optional_ar
Yuki
2015/11/30 06:53:23
Done.
|
| + if (argument_context['is_optional'] and |
| + not argument_context['has_default'] and |
| + not argument_context['is_dictionary'] and |
| + not argument_context['is_callback_interface'])), |
| 'idl_type': idl_type.base_type, |
| 'is_call_with_execution_context': has_extended_attribute_value(method, 'CallWith', 'ExecutionContext'), |
| 'is_call_with_script_arguments': is_call_with_script_arguments, |