third_party/WebKit/LayoutTests/storage/indexeddb/resources/intversion-bad-parameters.js - Issue 1476863003: bindings: Ignores the last undefined arguments when counting the args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/resources/intversion-bad-parameters.js

Issue 1476863003: bindings: Ignores the last undefined arguments when counting the args. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed a review comment. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/intversion-bad-parameters-expected.txt ('k') | third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-path-context-clip-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/storage/indexeddb/resources/intversion-bad-parameters.js

diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/resources/intversion-bad-parameters.js b/third_party/WebKit/LayoutTests/storage/indexeddb/resources/intversion-bad-parameters.js

index 3853fc3cabdc7017c1e40957e2725addf26903e3..062a7f02356d80c942b0c4fca048153b6355bfd8 100644

--- a/third_party/WebKit/LayoutTests/storage/indexeddb/resources/intversion-bad-parameters.js

+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/resources/intversion-bad-parameters.js

@@ -25,7 +25,9 @@ function deleteSuccess(evt) {

evalAndExpectExceptionClass("indexedDB.open(dbname, -1)", "TypeError");

evalAndExpectExceptionClass("indexedDB.open(dbname, 0x20000000000000)", "TypeError");

evalAndExpectExceptionClass("indexedDB.open(dbname, null)", "TypeError");

- evalAndExpectExceptionClass("indexedDB.open(dbname, undefined)", "TypeError");

+ // Unlike open(dbname, null), passing |undefined| to the second parameter

+ // (version) is okay because the version is an optional parameter.

+ shouldNotThrow("indexedDB.open(dbname, undefined)");

finishJSTest();

}