third_party/WebKit/LayoutTests/fast/css/counters/counter-reset-subtree-insert-crash.html - Issue 1476863003: bindings: Ignores the last undefined arguments when counting the args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css/counters/counter-reset-subtree-insert-crash.html

Issue 1476863003: bindings: Ignores the last undefined arguments when counting the args. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed a review comment. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-scroll-path-into-view.js ('k') | third_party/WebKit/LayoutTests/fast/events/clipboard-clearData.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css/counters/counter-reset-subtree-insert-crash.html

diff --git a/third_party/WebKit/LayoutTests/fast/css/counters/counter-reset-subtree-insert-crash.html b/third_party/WebKit/LayoutTests/fast/css/counters/counter-reset-subtree-insert-crash.html

index 0ffbdae05ea8d65057e4c956cfaa9f1e4b66841d..241ad069771f7f2db06be3918779bfe20ef22962 100644

--- a/third_party/WebKit/LayoutTests/fast/css/counters/counter-reset-subtree-insert-crash.html

+++ b/third_party/WebKit/LayoutTests/fast/css/counters/counter-reset-subtree-insert-crash.html

@@ -52,9 +52,9 @@ window.onload = function() {

];

stylesheet = document.styleSheets[0];

document.body.offsetTop;

- stylesheet.insertRule(rules[0], stylesheet.length);

+ stylesheet.insertRule(rules[0], stylesheet.cssRules.length);

document.body.offsetTop;

- stylesheet.insertRule(rules[1], stylesheet.length)

+ stylesheet.insertRule(rules[1], stylesheet.cssRules.length)

document.body.innerHTML = "PASS: reparenting a counter node subtree that contains resets does not cause a crash.";

}

</script>