third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js - Issue 1476863003: bindings: Ignores the last undefined arguments when counting the args.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js

Issue 1476863003: bindings: Ignores the last undefined arguments when counting the args. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed a review comment. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-scroll-path-into-view-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-path-context-clip.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js

diff --git a/third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js b/third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js

index aa03bcb9dffbbccae21f6abdc0f5e9bf2b56bfef..3d788aa2929c2001031e974dd8b087bb39c90d82 100644

--- a/third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js

+++ b/third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-isPointInPath-winding.js

@@ -38,6 +38,7 @@ function prepareTestScenario() {

path.rect(0, 0, 100, 100);

path.rect(25, 25, 50, 50);

shouldBeTrue("ctx.isPointInPath(path, 50, 50)");

+ shouldBeTrue("ctx.isPointInPath(path, 50, 50, undefined)");

shouldBeFalse("ctx.isPointInPath(path, NaN, 50)");

shouldBeFalse("ctx.isPointInPath(path, 50, NaN)");

debug('');

@@ -71,7 +72,6 @@ function prepareTestScenario() {

shouldThrow("ctx.isPointInPath(undefined, 50, 50, 'nonzero')");

shouldThrow("ctx.isPointInPath(undefined, 50, 50, 'evenodd')");

shouldThrow("ctx.isPointInPath(undefined, 50, 50, undefined)");

- shouldThrow("ctx.isPointInPath(path, 50, 50, undefined)");

shouldThrow("ctx.isPointInPath([], 50, 50)");

shouldThrow("ctx.isPointInPath([], 50, 50, 'nonzero')");

shouldThrow("ctx.isPointInPath([], 50, 50, 'evenodd')");