Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1476833002: [turbofan] Only allocate implict receiver when needed. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Only allocate implict receiver when needed. This adapts the constructor call inlining machinery to only allocate implicit receivers and perform the return value check if the callee needs it. R=verwaest@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/fe232cfd0804a7d2a7a74fb41928546d8752bfb1 Cr-Commit-Position: refs/heads/master@{#32337}

Patch Set 1 #

Patch Set 2 : Undo bogus change. #

Patch Set 3 : Redo correct change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -19 lines) Patch
M src/compiler/js-inlining.cc View 1 2 5 chunks +33 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Starzinger
Toon: PTAL. Benedikt: FYI.
5 years ago (2015-11-25 14:06:09 UTC) #2
Toon Verwaest
lgtm
5 years ago (2015-11-26 13:49:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476833002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476833002/40001
5 years ago (2015-11-26 13:51:22 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-26 13:58:23 UTC) #8
commit-bot: I haz the power
5 years ago (2015-11-26 13:58:36 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fe232cfd0804a7d2a7a74fb41928546d8752bfb1
Cr-Commit-Position: refs/heads/master@{#32337}

Powered by Google App Engine
This is Rietveld 408576698