Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: mojo/services/notifications/interfaces/notifications.mojom

Issue 1476823003: Fix notifications. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: modified mojom to allow client to device to play sound/vibrate/lights. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/notifications/interfaces/notifications.mojom
diff --git a/mojo/services/notifications/interfaces/notifications.mojom b/mojo/services/notifications/interfaces/notifications.mojom
index df36918a38d85d6d5b2eb64c641ecd58ca21f9a1..88ee46624812bf9adec9a31df67cc1f161399662 100644
--- a/mojo/services/notifications/interfaces/notifications.mojom
+++ b/mojo/services/notifications/interfaces/notifications.mojom
@@ -11,6 +11,17 @@ struct NotificationData {
// Text to be displayed along with the notification, if supported.
string? text;
+
+ // Indicates if notification sound must be played when notification is thrown.
Andrew T Wilson (Slow) 2015/11/26 09:36:27 nit: thrown->shown
+ bool play_sound;
+
+ // Indicates if the device should vibrate, if it supports.
Andrew T Wilson (Slow) 2015/11/26 09:36:27 nit: supports -> supports vibration.
+ bool vibrate;
+
+ // Indicates if notification lights must be set so that the lights can blink
+ // till the notification is attended.Note, this would depend on the device
Andrew T Wilson (Slow) 2015/11/26 09:36:27 Space before "Note"
+ // support for notification lights.
+ bool set_lights;
};
// Interaction with a posted notification will be communicated through the

Powered by Google App Engine
This is Rietveld 408576698