Fix notifications.

Fix notifications.

Also add vibrate, sound and loghts to notificatins.

R=qsr@chromium.org, vtl@google.com

Committed: https://chromium.googlesource.com/external/mojo/+/92f8038e1caa9d5518cf029daee5b45b2320189f

[ksimbili, 2015-11-25 19:37:52]

ksimbili@google.com changed reviewers:
+ atwilson@google.com

[ksimbili, 2015-11-25 19:41:25]

ksimbili@google.com changed reviewers:
+ anwilson@google.com
- atwilson@google.com

[anwilson, 2015-11-25 19:45:24]

Description was changed from

==========
Fix notifications.

Also add vibrate, sound and loghts to notificatins.
==========

to

==========
Fix notifications.

Also add vibrate, sound and loghts to notificatins.
==========

[anwilson, 2015-11-25 19:45:39]

https://codereview.chromium.org/1476823003/diff/1/services/notifications/src/...
File
services/notifications/src/org/chromium/mojo/notifications/NotificationBuilder.java
(right):

https://codereview.chromium.org/1476823003/diff/1/services/notifications/src/...
services/notifications/src/org/chromium/mojo/notifications/NotificationBuilder.java:63:
notificationBuilder.setSound(alarmSound);
vibrating, blinking led, and playing a sound might be a bit overkill each time a
notification shows up.

[ksimbili, 2015-11-25 23:04:04]

ksimbili@google.com changed reviewers:
+ qsr@chromium.org

[ksimbili, 2015-11-25 23:04:06]

https://codereview.chromium.org/1476823003/diff/1/services/notifications/src/...
File
services/notifications/src/org/chromium/mojo/notifications/NotificationBuilder.java
(right):

https://codereview.chromium.org/1476823003/diff/1/services/notifications/src/...
services/notifications/src/org/chromium/mojo/notifications/NotificationBuilder.java:63:
notificationBuilder.setSound(alarmSound);
On 2015/11/25 19:45:39, anwilson wrote:
> vibrating, blinking led, and playing a sound might be a bit overkill each time
a
> notification shows up.

Done.

[qsr, 2015-11-26 08:28:48]

lgtm

[Andrew T Wilson (Slow), 2015-11-26 09:36:26]

atwilson@chromium.org changed reviewers:
+ atwilson@chromium.org

[Andrew T Wilson (Slow), 2015-11-26 09:36:27]

https://codereview.chromium.org/1476823003/diff/40001/mojo/services/notificat...
File mojo/services/notifications/interfaces/notifications.mojom (right):

https://codereview.chromium.org/1476823003/diff/40001/mojo/services/notificat...
mojo/services/notifications/interfaces/notifications.mojom:15: // Indicates if
notification sound must be played when notification is thrown.
nit: thrown->shown

https://codereview.chromium.org/1476823003/diff/40001/mojo/services/notificat...
mojo/services/notifications/interfaces/notifications.mojom:18: // Indicates if
the device should vibrate, if it supports.
nit: supports -> supports vibration.

https://codereview.chromium.org/1476823003/diff/40001/mojo/services/notificat...
mojo/services/notifications/interfaces/notifications.mojom:22: // till the
notification is attended.Note, this would depend on the device
Space before "Note"

[ksimbili, 2015-11-26 14:50:26]

ksimbili@google.com changed reviewers:
+ vtl@google.com

[ksimbili, 2015-11-26 14:50:27]

Adding +vtl for permission to land

[vtl, 2015-11-30 17:44:32]

Rubberstamp lgtm (but qsr's lgtm was really enough).

Is "git cl land" not working for you? If you are, you should probably talk to
jamesr (I literally don't have the power to help you)....

[ksimbili, 2015-11-30 19:21:50]

Description was changed from

==========
Fix notifications.

Also add vibrate, sound and loghts to notificatins.
==========

to

==========
Fix notifications.

Also add vibrate, sound and loghts to notificatins.

R=qsr@chromium.org, vtl@google.com

Committed:
https://chromium.googlesource.com/external/mojo/+/92f8038e1caa9d5518cf029daee...
==========

[ksimbili, 2015-11-30 19:21:51]

Committed patchset #5 (id:80001) manually as
92f8038e1caa9d5518cf029daee5b45b2320189f (presubmit successful).