Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1476763006: Revert of [compiler] merge binary-operator-reducer (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
titzer, fedor.indutny
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [compiler] merge binary-operator-reducer (patchset #2 id:20001 of https://codereview.chromium.org/1473073004/ ) Reason for revert: Unsound use of types in the MachineOperatorReducer. Will work on a sound solution with Fedor. Original issue's description: > [compiler] merge binary-operator-reducer > > Merge BinaryOperatorReducer into the MachineOperatorReducer class. > It does not need `Revisit()` calls, because the newly inserted nodes are > visited anyway, and there are no other methods that need AdvancedReducer > there. > > BUG= > R=titzer@chromium.org > > Committed: https://crrev.com/993ba9d2529a6401b3040b9263f8d06db7dbb4f1 > Cr-Commit-Position: refs/heads/master@{#32298} TBR=titzer@chromium.org,fedor@indutny.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/b0c179daf686ffbb36e5a72e1063cd3f80c310dc Cr-Commit-Position: refs/heads/master@{#32310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -146 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/compiler/binary-operator-reducer.h View 1 chunk +52 lines, -0 lines 0 comments Download
A src/compiler/binary-operator-reducer.cc View 1 chunk +128 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 3 chunks +2 lines, -84 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A test/unittests/compiler/binary-operator-reducer-unittest.cc View 1 chunk +94 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
Created Revert of [compiler] merge binary-operator-reducer
5 years ago (2015-11-26 03:51:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476763006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476763006/1
5 years ago (2015-11-26 03:52:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 03:52:24 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-26 03:52:38 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b0c179daf686ffbb36e5a72e1063cd3f80c310dc
Cr-Commit-Position: refs/heads/master@{#32310}

Powered by Google App Engine
This is Rietveld 408576698