Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1476763004: Remove unused code from WebMimeRegistry. (Closed)

Created:
5 years ago by jbroman
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused code from WebMimeRegistry. WebCommon.h is never used in this header. WebMimeRegistry::mimeTypeFromFile has no call sites (and I can't find any in the last 4+ years). Committed: https://crrev.com/bd4072ae2f7ad210c137e997dcbb7eb12802e039 Cr-Commit-Position: refs/heads/master@{#362010}

Patch Set 1 #

Patch Set 2 : remove implementations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M components/html_viewer/web_mime_registry_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/web_mime_registry_impl.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/mime_registry_message_filter.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M content/child/simple_webmimeregistry_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/child/simple_webmimeregistry_impl.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M content/common/mime_registry_messages.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 chunks +0 lines, -15 lines 0 comments Download
M third_party/WebKit/public/platform/WebMimeRegistry.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jbroman
The bots seem to agree that nobody calls this, so the interface and three implementations ...
5 years ago (2015-11-25 21:31:35 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-11-26 13:24:18 UTC) #5
Mike West
LGTM 2. :)
5 years ago (2015-11-27 05:05:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476763004/20001
5 years ago (2015-11-27 14:08:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-27 16:45:14 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-27 16:46:09 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd4072ae2f7ad210c137e997dcbb7eb12802e039
Cr-Commit-Position: refs/heads/master@{#362010}

Powered by Google App Engine
This is Rietveld 408576698