test/cctest/test-macro-assembler-x64.cc - Issue 1476763002: Make whether or not a Code object should be created by masm explicit

Unified Diff: test/cctest/test-macro-assembler-x64.cc

Issue 1476763002: Make whether or not a Code object should be created by masm explicit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-macro-assembler-x64.cc

diff --git a/test/cctest/test-macro-assembler-x64.cc b/test/cctest/test-macro-assembler-x64.cc

index 575aedf659a57a3f23358a70ef873bb0058d14e5..ae37bfc806babd635c75f36523706eb2a3fa2f3d 100644

--- a/test/cctest/test-macro-assembler-x64.cc

+++ b/test/cctest/test-macro-assembler-x64.cc

@@ -154,7 +154,8 @@ TEST(SmiMove) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler; // Create a pointer for the __ macro.

EntryCode(masm);

Label exit;

@@ -239,7 +240,8 @@ TEST(SmiCompare) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -287,7 +289,8 @@ TEST(Integer32ToSmi) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -413,7 +416,8 @@ TEST(Integer64PlusConstantToSmi) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -455,7 +459,8 @@ TEST(SmiCheck) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -674,7 +679,8 @@ TEST(SmiNeg) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -885,7 +891,8 @@ TEST(SmiAdd) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -1101,7 +1108,8 @@ TEST(SmiSub) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -1189,7 +1197,8 @@ TEST(SmiMul) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -1292,7 +1301,8 @@ TEST(SmiDiv) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -1399,7 +1409,8 @@ TEST(SmiMod) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -1493,7 +1504,8 @@ TEST(SmiIndex) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -1559,7 +1571,8 @@ TEST(SmiSelectNonSmi) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -1635,7 +1648,8 @@ TEST(SmiAnd) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -1713,7 +1727,8 @@ TEST(SmiOr) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -1793,7 +1808,8 @@ TEST(SmiXor) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -1857,7 +1873,8 @@ TEST(SmiNot) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -1950,7 +1967,8 @@ TEST(SmiShiftLeft) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -2053,7 +2071,8 @@ TEST(SmiShiftLogicalRight) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -2119,7 +2138,8 @@ TEST(SmiShiftArithmeticRight) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -2180,7 +2200,8 @@ TEST(PositiveSmiTimesPowerOfTwoToInteger64) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

EntryCode(masm);

@@ -2220,7 +2241,8 @@ TEST(OperandOffset) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler;

Label exit;

@@ -2570,7 +2592,8 @@ TEST(LoadAndStoreWithRepresentation) {

CHECK(buffer);

Isolate* isolate = CcTest::i_isolate();

HandleScope handles(isolate);

- MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size));

+ MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),

+ true);

MacroAssembler* masm = &assembler; // Create a pointer for the __ macro.

EntryCode(masm);

__ subq(rsp, Immediate(1 * kPointerSize));

« src/arm/macro-assembler-arm.h ('K') | « test/cctest/test-macro-assembler-mips64.cc ('k') | test/cctest/test-macro-assembler-x87.cc » ('j') | no next file with comments »