src/arm/code-stubs-arm.h - Issue 1476763002: Make whether or not a Code object should be created by masm explicit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/code-stubs-arm.h

Issue 1476763002: Make whether or not a Code object should be created by masm explicit (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/code-stubs-arm.h

diff --git a/src/arm/code-stubs-arm.h b/src/arm/code-stubs-arm.h

index 845e38a85ed06224d0d5d5d6cfad4f2c1074f037..337b48df30ac918c0f67e4c74b52a2208e3703ec 100644

--- a/src/arm/code-stubs-arm.h

+++ b/src/arm/code-stubs-arm.h

@@ -109,9 +109,8 @@ class RecordWriteStub: public PlatformCodeStub {

}

static void Patch(Code* stub, Mode mode) {

- MacroAssembler masm(NULL,

- stub->instruction_start(),

- stub->instruction_size());

+ MacroAssembler masm(stub->GetIsolate(), stub->instruction_start(),

+ stub->instruction_size(), false);

switch (mode) {

case STORE_BUFFER_ONLY:

DCHECK(GetMode(stub) == INCREMENTAL ||

« no previous file with comments | « no previous file | src/arm/codegen-arm.cc » ('j') | src/arm/macro-assembler-arm.h » ('J')