[pylib/devil] Create devil.android.base_tool and derive valgrind_tools classes from it

[pylib/devil] Create devil.android.base_tool and derive valgrind_tools classes from it.

This helps remove forwarder's dependency on pylib.valgrind_tools

BUG=561582
Committed: https://crrev.com/88c4af1e2b654dbdf64113a8c77a2210dc36b3b6
Cr-Commit-Position: refs/heads/master@{#361758}

[nednguyen, 2015-11-25 17:42:31]

nednguyen@google.com changed reviewers:
+ jbudorick@chromium.org

[nednguyen, 2015-11-25 17:43:08]

Description was changed from

==========
[pylib/devil] Create devil.android.base_tool and derive valgrind_tools classes
from it

BUG=561582
==========

to

==========
[pylib/devil] Create devil.android.base_tool and derive valgrind_tools classes
from it.

This helps remove forwarder's dependency on pylib.valgrind_tools

BUG=561582
==========

[jbudorick, 2015-11-25 17:51:52]

lgtm w/ nit

https://codereview.chromium.org/1476723003/diff/1/build/android/devil/android...
File build/android/devil/android/base_tool.py (right):

https://codereview.chromium.org/1476723003/diff/1/build/android/devil/android...
build/android/devil/android/base_tool.py:6: class BaseTool(object):
nit: create devil/android/valgrind_tools and put this in there. As-is,
"devil.android.base_tool" is very ambiguous.

[nednguyen, 2015-11-25 18:03:51]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2015-11-25 18:03:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1476723003/#ps20001
(title: "Address John's comment")

[commit-bot: I haz the power, 2015-11-25 18:04:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476723003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476723003/20001

[commit-bot: I haz the power, 2015-11-25 22:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 22:39:10]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[nednguyen, 2015-11-25 22:42:28]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-11-25 22:44:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476723003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476723003/20001

[commit-bot: I haz the power, 2015-11-26 00:30:23]

Description was changed from

==========
[pylib/devil] Create devil.android.base_tool and derive valgrind_tools classes
from it.

This helps remove forwarder's dependency on pylib.valgrind_tools

BUG=561582
==========

to

==========
[pylib/devil] Create devil.android.base_tool and derive valgrind_tools classes
from it.

This helps remove forwarder's dependency on pylib.valgrind_tools

BUG=561582
==========

[commit-bot: I haz the power, 2015-11-26 00:30:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-26 00:32:25]

Description was changed from

==========
[pylib/devil] Create devil.android.base_tool and derive valgrind_tools classes
from it.

This helps remove forwarder's dependency on pylib.valgrind_tools

BUG=561582
==========

to

==========
[pylib/devil] Create devil.android.base_tool and derive valgrind_tools classes
from it.

This helps remove forwarder's dependency on pylib.valgrind_tools

BUG=561582

Committed: https://crrev.com/88c4af1e2b654dbdf64113a8c77a2210dc36b3b6
Cr-Commit-Position: refs/heads/master@{#361758}
==========

[commit-bot: I haz the power, 2015-11-26 00:32:25]

Patchset 2 (id:??) landed as
https://crrev.com/88c4af1e2b654dbdf64113a8c77a2210dc36b3b6
Cr-Commit-Position: refs/heads/master@{#361758}