Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2803)

Unified Diff: chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc

Issue 14767029: Add API function chrome.notifications.getAll (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: IWYU + dimich nit. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc
diff --git a/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc b/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc
index 0fee6235d2abf5817725c860fd41eb37ae965b7a..2fc4db797820039c946416bdfc0c790f6dc6dac5 100644
--- a/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc
+++ b/chrome/browser/notifications/sync_notifier/chrome_notifier_service_unittest.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/notifications/notification_ui_manager.h"
#include "chrome/browser/notifications/sync_notifier/chrome_notifier_service.h"
#include "chrome/browser/notifications/sync_notifier/synced_notification.h"
+#include "chrome/browser/profiles/profile.h"
#include "sync/api/sync_change.h"
#include "sync/api/sync_change_processor.h"
#include "sync/api/sync_error_factory.h"
@@ -122,6 +123,7 @@ class StubNotificationUIManager : public NotificationUIManager {
OVERRIDE {
// Make a deep copy of the notification that we can inspect.
notification_ = notification;
+ profile_ = profile;
}
// Returns true if any notifications match the supplied ID, either currently
@@ -136,6 +138,18 @@ class StubNotificationUIManager : public NotificationUIManager {
return false;
}
+ // Adds the notification_id for each outstanding notification to the set
+ // |notification_ids| (must not be NULL).
+ virtual std::set<std::string> GetAllIdsByProfileAndSourceOrigin(
+ Profile* profile,
+ const GURL& source) OVERRIDE {
+ std::set<std::string> notification_ids;
+ if (source == notification_.origin_url() &&
+ profile->IsSameProfile(profile_))
+ notification_ids.insert(notification_.notification_id());
+ return notification_ids;
+ }
+
// Removes notifications matching the |source_origin| (which could be an
// extension ID). Returns true if anything was removed.
virtual bool CancelAllBySourceOrigin(const GURL& source_origin) OVERRIDE {
@@ -157,6 +171,7 @@ class StubNotificationUIManager : public NotificationUIManager {
private:
DISALLOW_COPY_AND_ASSIGN(StubNotificationUIManager);
Notification notification_;
+ Profile* profile_;
};
// Dummy SyncChangeProcessor used to help review what SyncChanges are pushed

Powered by Google App Engine
This is Rietveld 408576698