Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1776)

Unified Diff: tools/dom/scripts/fremontcutbuilder.py

Issue 14767027: Relax feature defines restrictions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/databasebuilder.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/fremontcutbuilder.py
diff --git a/tools/dom/scripts/fremontcutbuilder.py b/tools/dom/scripts/fremontcutbuilder.py
index 8f440dae8e5559aca61fb2f02250776c090a917a..3b172b2556762944d6869cc352de4863a71feac8 100755
--- a/tools/dom/scripts/fremontcutbuilder.py
+++ b/tools/dom/scripts/fremontcutbuilder.py
@@ -10,6 +10,8 @@ import logging.config
import os.path
import sys
+_logger = logging.getLogger('fremontcutbuilder')
+
FEATURE_DISABLED = [
'ENABLE_BATTERY_STATUS',
'ENABLE_CSS3_CONDITIONAL_RULES',
@@ -107,12 +109,12 @@ def build_database(idl_files, database_dir, feature_defines=None, parallel=False
unused_conditionals = known_conditionals - conditionals_met
if unused_conditionals:
- raise Exception('There are some unused conditionals %s' %
+ _logger.warning('There are some unused conditionals %s' %
sorted(unused_conditionals))
unknown_conditionals = conditionals_met - known_conditionals
if unknown_conditionals:
- raise Exception('There are some unknown conditionals %s' %
+ _logger.warning('There are some unknown conditionals %s' %
sorted(unknown_conditionals))
db.Save()
« no previous file with comments | « tools/dom/scripts/databasebuilder.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698