Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14767019: [content shell] move code common to several processes to a common dir (Closed)

Created:
7 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, vsevik, sadrul, ben+watch_chromium.org, tfarina, jam, yurys, joi+watch-content_chromium.org, sail+watch_chromium.org, darin-cc_chromium.org, pfeldman, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] move code common to several processes to a common dir BUG=180021 TBR=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -664 lines) Patch
M ash/shell/content_client/shell_main_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_shell.gypi View 3 chunks +10 lines, -10 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/common/shell_content_client.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/common/shell_content_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/shell/common/shell_messages.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/common/shell_messages.cc View 1 chunk +6 lines, -6 lines 0 comments Download
A + content/shell/common/shell_switches.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/common/shell_switches.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/common/shell_test_configuration.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/common/shell_test_configuration.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/shell/common/webkit_test_helpers.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/common/webkit_test_helpers.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/notify_done_forwarder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/shell_render_process_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/shell.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/shell/shell_browser_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_browser_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D content/shell/shell_content_client.h View 1 chunk +0 lines, -32 lines 0 comments Download
D content/shell/shell_content_client.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M content/shell/shell_devtools_frontend.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_javascript_dialog_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_main_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_main_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/shell_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/shell/shell_messages.h View 1 chunk +0 lines, -103 lines 0 comments Download
D content/shell/shell_messages.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M content/shell/shell_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/shell/shell_switches.h View 1 chunk +0 lines, -25 lines 0 comments Download
D content/shell/shell_switches.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D content/shell/shell_test_configuration.h View 1 chunk +0 lines, -43 lines 0 comments Download
D content/shell/shell_test_configuration.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M content/shell/shell_url_request_context_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_web_contents_view_delegate_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_web_contents_view_delegate_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_web_contents_view_delegate_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/webkit_test_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D content/shell/webkit_test_helpers.h View 1 chunk +0 lines, -40 lines 0 comments Download
D content/shell/webkit_test_helpers.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M content/test/content_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_test_launcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/layout_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/content_client/examples_main_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
7 years, 7 months ago (2013-05-07 13:00:23 UTC) #1
marja
lgtm
7 years, 7 months ago (2013-05-07 13:13:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/14767019/1
7 years, 7 months ago (2013-05-07 13:15:51 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-07 13:26:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/14767019/1
7 years, 7 months ago (2013-05-07 13:31:59 UTC) #5
jochen (gone - plz use gerrit)
7 years, 7 months ago (2013-05-07 14:42:17 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 manually as r198723 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698