Issue 14767011: Add base/android/activity_status.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14767011: Add base/android/activity_status.cc (Closed)

Created:
7 years, 7 months ago by Philippe

Modified:
7 years, 7 months ago

Reviewers:
digit1

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add base/android/activity_status.cc This patch adds a small thread-safe wrapper around the Java org.chromium.base.ActivityStatus that can be used to listen to activity state changes from native code. This uses a base::ObserverListThreadSafe to guarantee that listeners can be registered on any threads, and that their OnActivityStateChange() method will always be called on the thread that created them. + Ensure both C++ and Java always use the same constants when it comes to ActivityState values. TBR=digit@chromium.org BUG=233536 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198124

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+386 lines, -8 lines)			Patch
A	base/android/activity_state_list.h	View		1 chunk	+16 lines, -0 lines	0 comments	Download
A	base/android/activity_status.h	View	1	1 chunk	+97 lines, -0 lines	0 comments	Download
A	base/android/activity_status.cc	View		1 chunk	+66 lines, -0 lines	0 comments	Download
A	base/android/activity_status_unittest.cc	View	1	1 chunk	+129 lines, -0 lines	0 comments	Download
M	base/android/base_jni_registrar.cc	View	1 2	3 chunks	+3 lines, -1 line	0 comments	Download
A	base/android/java/src/org/chromium/base/ActivityState.template	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	base/android/java/src/org/chromium/base/ActivityStatus.java	View		2 chunks	+38 lines, -7 lines	0 comments	Download
M	base/base.gyp	View	1 2	4 chunks	+21 lines, -0 lines	0 comments	Download
M	base/base.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Philippe

For the record, Patch Set #1 is David's CL which was reviewed on https://chromiumcodereview.appspot.com/14373019/.

7 years, 7 months ago (2013-05-03 14:17:22 UTC) #1

Philippe

Committed patchset #3 manually as r198124 (presubmit successful).

7 years, 7 months ago (2013-05-03 16:29:27 UTC) #2

Ted C

7 years, 7 months ago (2013-05-03 18:18:47 UTC) #3

Message was sent while issue was closed.

On 2013/05/03 16:29:27, Philippe wrote:
> Committed patchset #3 manually as r198124 (presubmit successful).

The android IndexedDBBrowser tests are failing after this landed...no idea if
it's related, but this is the only meaty change in the failure window.  Might
need to give a speculative revert.  Will revert the revert if I'm wrong.

Expand Messages | Collapse Messages

Issue 14767011: Add base/android/activity_status.cc (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix flakiness #

Patch Set 3 : Sync #

Messages